ci(nightly): run the version step in bash on Windows (#1609)

This commit is contained in:
4gray authored and GitHub committed 2026-09-15 20:47:55 +02:00
1 parent 6f7973a9fb
commit d3dee05a84
2 files changed
+12

No files matched your search

+3
View File
@@ -495,6 +495,9 @@ jobs:
# comes from the nightly-version job so every job of this run
# builds the same version.
if: needs.nightly-version.outputs.version != ''
# Windows runners default to PowerShell, where "${NIGHTLY_VERSION}"
# expands to nothing and the script rejects the empty version.
shell: bash
env:
NIGHTLY_VERSION: ${{ needs.nightly-version.outputs.version }}
run: node tools/release/nightly-version.mjs --apply --version "${NIGHTLY_VERSION}"
@@ -479,6 +479,15 @@ test('keeps non-Linux builds independent from the Linux runtime prerequisite', (
);
assert.equal(linuxJob.strategy['fail-fast'], false);
assert.deepEqual(linuxJob.steps, crossPlatformJob.steps);
// Windows runners default to PowerShell, where the bash-style
// "${NIGHTLY_VERSION}" expands to nothing and the version script rejects
// the empty value; the step must pin bash on every host.
const applyNightlyVersion = crossPlatformJob.steps.find(
(step) => step.name === 'Apply nightly version'
);
assert.ok(applyNightlyVersion);
assert.equal(applyNightlyVersion.shell, 'bash');
assert.match(applyNightlyVersion.run, /--version "\$\{NIGHTLY_VERSION\}"/);
assert.deepEqual(buildWorkflowConfig.jobs['create-release'].needs, [
'nightly-version',
'build-cross-platform',