* fix(i18n): translate hard-coded labels, snackbars and missing keys Catalog screens, snackbars and external player messages showed English in every locale, and seven keys used in code were missing from en.json, so ngx-translate rendered them raw. - Catalog: "All items", item and channel counts, channel sort menus and tooltips, unnamed-category and empty-category labels, LIVE/PAUSED badges and the Xtream global search summary are translated. The Xtream and Stalker stores no longer bake an English name into the every-item sentinel; the facades return a null title and the view translates it. - Snackbars: Xtream/Stalker request failures, the 413 upload error, backup export/import results and the category visibility failure use keys; every "Close" action uses CLOSE. - External player: the main process sends an error code instead of an English sentence (player-error event, session errorCode, and a tag in rejected launch errors); the renderer, dock and VOD primary button translate it. The external player info dialog is translated. - Adds the seven missing keys and 43 new ones, translated in all 18 locales; seven legitimately identical values are baselined. - tools/i18n/check-usage.mjs fails on keys used in code but missing from en.json; it runs in i18n:check (and so in CI through i18n:validate). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(i18n): translate catalog counts in the template and skip inline template comments - The category subtitle hands a key to the translate pipe instead of caching translate.instant(), so a cold start re-renders it once the language file loads. - The Xtream live root count uses the singular/plural item keys, so one result no longer reads "1 channels". - check-usage.mjs strips HTML comments inside inline templates of TypeScript files, so a commented-out key no longer fails the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(i18n): check keys in parenthesised translate pipe operands `(expanded() ? 'SHOW_LESS' : 'SHOW_MORE') | translate` yields keys that neither precede the pipe directly nor contain a dot, so the usage check missed them. It now reads the ternary and fallback branches of a parenthesised operand; a literal compared in the condition is not read as a key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(e2e): expect the translated external player failure in the dock A launch failure without an error code now shows the translated generic status in the playback dock, with the raw main-process detail as its tooltip. The ClearKey DASH flow asserted the raw English text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(playback): keep the IPC error tag out of the stored session detail A tagged launch failure reached ExternalPlayerSession.error unchanged, so the dock tooltip showed "[iptvnator:external-player:start-failed]". The registry now strips the tag when it stores the detail; the rejected IPC error keeps it for the renderer to read the code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(web): expect translated portal request failure toasts #1861's new resolved-failure specs asserted the English toast text; the toasts now go through PORTALS.REQUEST_ERRORS keys, so the specs check the key and its message/status params. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(i18n): read only returned branches of a grouped translate operand A literal at the start of a condition, as in `('ERROR' === status() ? 'CLOSE' : 'CLOSE') | translate`, was taken for a translation key, so a valid template could fail the usage check. A grouped literal now counts only when it ends its operand (end of group, `:`, `||` or `??`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(i18n): translate the remaining hard-coded labels Follow-up to the UI-26 pass. The remaining English UI literals now come from translation keys, translated in all 18 locales: - Windows/Linux window controls, playlist switcher title and actions menu, the portal status tooltip, dashboard carousel roles and rail scroll buttons, the search placeholder, the card remove tooltip, the EPG offset unit, the REC chip, the Stalker EPG source label and the export file type. - Embedded MPV failures raised in the renderer and the release-notes dialog without a bridge. Settings never showed its English reasons, so they are dropped. - Unnamed Stalker episodes: data access leaves the title empty and the series view labels it after the TMDB overlay. Synthetic season names stay, because they key persisted episode progress. - The phone remote-control page, which follows the first browser language with a translation and sets <html lang>. Removes the dead getStatusMessage(), the unused favorites layout and the translateWithFallback() helpers whose keys now exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(remote-control): keep the remote build off shared-interfaces The language resolver imported the Language enum, which made remote-control-web depend on shared-interfaces. Its build-performance chain then hit Nx's recursive-invocation guard through the existing shared-interfaces/shared-logging build loop, failing the Electron E2E and performance journey builds. The resolver now keeps its own list of translation codes, and a spec checks it against the locale files the page loads. Also drops the deleted favorites layout from the zoneless checklist, whose guard spec requires ticked entries to exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * perf(journeys): raise the launch DOM mutation baseline for translated attributes Launch now sets 569 DOM mutations before the first dashboard card instead of 557 (identical in all three CI iterations). The extra twelve come from attributes this PR moved from static English to translated bindings on the launch path: the window-control labels and tooltips on Linux, the hero carousel and slide roles, and the rail scroll-button labels. A translated attribute is a binding set after the element is attached, so each costs a mutation. Accepted as a deliberate trade-off; it needs the perf-baseline-increase label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
21 KiB
Zoneless change-detection migration
Working checklist for plan item C6 of the performance journeys plan: move the
renderer (apps/web) from zone.js to provideZonelessChangeDetection().
The win is measured with the change-detection tick counters described in
performance journeys; the
idle work audit found the Eager roots that
re-render on every tick. Update this file in the same PR that converts an item.
The inventory was taken on e8b181fce (2026-10-04, Angular 22.1.6). Run
pnpm nx run electron-backend-e2e:test-performance-harness after editing the
Eager list: zoneless-migration.spec.ts fails when the list and the code
disagree, so a new Eager component cannot land unnoticed and a converted one
must be ticked here.
Starting point
- OnPush is already the default. Since Angular 22 an unset
changeDetectionmeans OnPush, and the oldDefaultstrategy is spelledChangeDetectionStrategy.Eager. Only components that setEagerare checked on every tick.ChangeDetectionStrategy.Defaultis not used. - Renderer bootstrap.
apps/web/src/app/app.config.tsprovidesprovideZoneChangeDetection({ eventCoalescing: true })andapps/web/project.jsonbuilds with"polyfills": ["zone.js"].apps/remote-control-webdoes the same; it is a separate app and outside this migration unless a step says otherwise. - Unit tests already run zoneless. Every
src/test-setup.ts(apps/web, apps/remote-control-web and 24 libs) callssetupZonelessTestEnvand loadszone.js/zone.js/testingonly forfakeAsyncandwaitForAsync. A component that passes its specs is therefore not proof of zone-free production behavior when the spec callsfixture.detectChanges()itself. - IPC callbacks never ran in the Angular zone.
window.electron.on*listeners arrive throughcontextBridgeand are not zone-patched, so every one that works today already writes signals or callsNgZone.run. - Counters before the migration (macOS, from
performance journeys):
renderer.cdTicksToFirstCard20–21 (the one-tick zone.js race),renderer.cdTicksIdle30s3,renderer.cdTicksToFirstPage22;renderer.cdTicksToPlayinghas no recorded run yet.
PR sequence
- Keep
@ngrx/store-devtoolsout of production bundles (#1810, open). Not a zone change; it loweredrenderer.initialBytesbefore the migration starts moving it. - This inventory and its guard spec.
- Per-project PRs, in this order, each converting the project's Eager
components and fixing its zone-dependent sites while zone.js stays on:
libs/ui/*,libs/workspace/*,libs/playlist/*,libs/portal/*, playback (libs/ui/playback,libs/playlist/m3u/feature-player),apps/web. Each reports the tick counters before and after and runs the affected unit and E2E tests. provideZonelessChangeDetection()behind a build-timefileReplacementsflag, off by default; the three implemented journeys (J1-J3; J4 is still planned) and the Electron E2E suite run with it on (see Zoneless flag).- Flag on by default,
zone.jsout ofpolyfills, new tick baselines (renderer.cdTicksIdle30sand any counter that becomes deterministic once the zone.js race is gone).
Eager components
65 production files, 66 components (epg-progress-panel.component.ts holds
two). Tick an entry by deleting changeDetection: ChangeDetectionStrategy.Eager
(or setting OnPush) once its template state is signals, signal inputs or
explicitly marked. The guard spec compares the unticked entries with the
files whose component metadata still sets
changeDetection: ChangeDetectionStrategy.Eager (comments do not count).
The settings sections read form values in their templates and the parent
patches the form outside their events (Discard, backup import, the EPG file
picker), so each marks itself on the form's events through
markSectionForCheckOnFormEvents (apps/web/src/app/settings).
apps/web (15)
apps/web/src/app/app.component.ts(idle audit root)apps/web/src/app/app-update-notification-panel.component.ts(idle audit root)apps/web/src/app/settings/app-update-release-notes-dialog.component.tsapps/web/src/app/settings/settings.component.tsapps/web/src/app/settings/settings-about-section.component.tsapps/web/src/app/settings/settings-backup-section.component.tsapps/web/src/app/settings/settings-dashboard-section.component.tsapps/web/src/app/settings/settings-delete-all-playlists-dialog.component.tsapps/web/src/app/settings/settings-epg-section.component.tsapps/web/src/app/settings/settings-general-section.component.tsapps/web/src/app/settings/settings-playback-section.component.tsapps/web/src/app/settings/settings-remote-control-section.component.tsapps/web/src/app/settings/settings-tmdb-section.component.tsapps/web/src/app/settings/settings-unsaved-changes-dialog.component.ts
libs/ui (20 files, 21 components)
libs/ui/components/src/lib/confirm-dialog/confirm-dialog.component.tslibs/ui/components/src/lib/content-hero/content-hero.component.tslibs/ui/components/src/lib/expandable-text/expandable-text.component.tslibs/ui/components/src/lib/portal-detail-shell/content-about.component.tslibs/ui/components/src/lib/portal-detail-shell/portal-detail-shell.component.tslibs/ui/components/src/lib/progress-capsule/progress-capsule.component.tslibs/ui/components/src/lib/season-container/episode-info-dialog.component.tslibs/ui/components/src/lib/watched-badge/watched-badge.component.tslibs/ui/epg/src/lib/epg-item-description/epg-item-description.component.tslibs/ui/epg/src/lib/epg-progress-panel/epg-progress-panel.component.ts(idle audit root; alsoEpgTrustConfirmDialogComponent)libs/ui/epg/src/lib/epg-source-status/epg-source-status.component.tslibs/ui/remote-control/src/lib/remote-control/remote-control.component.ts(apps/remote-control-webonly)libs/ui/playback/src/lib/art-player/art-player.component.tslibs/ui/playback/src/lib/audio-player/audio-player.component.tslibs/ui/playback/src/lib/external-player-info-dialog/external-player-info-dialog.component.tslibs/ui/playback/src/lib/html-video-player/html-video-player.component.tslibs/ui/playback/src/lib/video-player/sidebar/sidebar.component.tslibs/ui/playback/src/lib/vjs-player/vjs-player.component.tslibs/ui/playback/src/lib/vod-details/vod-details.component.tslibs/ui/playback/src/lib/web-player-view/web-player-view.component.ts
libs/ui/playback (8) goes with the playback PR, not the libs/ui one.
apps/remote-control-web (1)
apps/remote-control-web/src/app/app.ts(separate app; converts withremote-control.component.ts)
libs/workspace (7)
libs/workspace/shell/feature/src/lib/workspace-command-palette/workspace-command-palette.component.tslibs/workspace/shell/feature/src/lib/workspace-context-panel/workspace-collection-context-panel.component.tslibs/workspace/shell/feature/src/lib/workspace-context-panel/workspace-context-panel.component.tslibs/workspace/shell/feature/src/lib/workspace-context-panel/workspace-settings-context-panel.component.tslibs/workspace/shell/feature/src/lib/workspace-keyboard-shortcuts/workspace-keyboard-shortcuts-dialog.component.tslibs/workspace/shell/feature/src/lib/workspace-shell/workspace-shell.component.ts(idle audit root)libs/workspace/shell/feature/src/lib/workspace-sources/workspace-sources.component.ts
libs/playlist (14)
libs/playlist/import/feature/src/lib/add-playlist-dialog/add-playlist-dialog.component.tslibs/playlist/import/feature/src/lib/auto-import/auto-import.component.tslibs/playlist/import/feature/src/lib/file-upload/file-upload.component.tslibs/playlist/import/feature/src/lib/stalker-portal-import/stalker-portal-import.component.tslibs/playlist/import/feature/src/lib/text-import/text-import.component.tslibs/playlist/import/feature/src/lib/url-upload/url-upload.component.tslibs/playlist/import/feature/src/lib/xtream-code-import/xtream-code-import.component.tslibs/playlist/m3u/feature-player/src/lib/m3u-vod-detail/m3u-vod-detail.component.tslibs/playlist/m3u/feature-player/src/lib/video-player/video-player.component.tslibs/playlist/shared/ui/src/lib/recent-playlists/empty-state/empty-state.component.tslibs/playlist/shared/ui/src/lib/recent-playlists/playlist-info/playlist-info.component.tslibs/playlist/shared/ui/src/lib/recent-playlists/playlist-item/playlist-item.component.tslibs/playlist/shared/ui/src/lib/source-health/source-cleanup-dialog.component.tslibs/playlist/shared/ui/src/lib/source-health/source-health-indicator.component.ts
libs/playlist/m3u/feature-player (2) goes with the playback PR.
libs/portal (8)
libs/portal/shared/ui/src/lib/components/playlist-error-view/playlist-error-view.component.tslibs/portal/shared/ui/src/lib/components/search-form/search-form.component.tslibs/portal/shared/ui/src/lib/navigation/portal-rail-links.component.tslibs/portal/stalker/feature/src/lib/stalker-catalog-detail/stalker-catalog-detail.component.tslibs/portal/stalker/feature/src/lib/stalker-favorites-button/stalker-favorites-button.component.tslibs/portal/stalker/feature/src/lib/stalker-series-view/stalker-series-view.component.tslibs/portal/xtream/feature/src/lib/global-search-results/global-search-results.component.tslibs/portal/xtream/feature/src/lib/serial-details/serial-details.component.ts
Test-only files that set Eager are not listed; they do not ship. The guard
skips every *.spec.ts / *.test.ts file with or without a suffix of one
or more segments (*.spec-stubs.ts, *.test-helpers.ts,
*.test-data-stubs.ts, …),
test-setup.ts and test-stubs/ directories.
Zone-dependent sites
Plain (non-signal) fields read by a template and written from a callback
that is not an Angular template event. Under zone.js the next tick happens to
refresh an Eager view; under zoneless nothing schedules one. Each fix makes
the field a signal (or a computed), or writes it through one.
| Done | Site | What depends on the zone | Owning PR |
|---|---|---|---|
| [x] | libs/playlist/m3u/feature-player/src/lib/video-player/video-player.component.ts onChannelNumberInput/clearChannelNumberInput |
2 s window.setTimeout hides the channel-number overlay through plain showChannelNumberOverlay/channelNumberInput |
playback |
| [x] | same file, applySettings and the settings effect() |
IndexedDB storage.get(...).subscribe and an effect assign plain playerSettings, which picks the player in the template |
playback |
| [x] | libs/playlist/shared/ui/src/lib/recent-playlists/playlist-item/playlist-item.component.ts checkPortalStatus |
plain portalStatus assigned after await in ngOnInit (PWA only: skipped when source health is supported) |
playlist |
| [x] | libs/playlist/shared/ui/src/lib/recent-playlists/playlist-info/playlist-info.component.ts (EPG clear and EPG file pick handlers) |
plain playlist reassigned after await |
playlist |
| [x] | libs/playlist/import/feature/src/lib/stalker-portal-import/stalker-portal-import.component.ts (device-id derivation) |
form.patchValue after await; no fix needed: while derivation is on hasManualDeviceIds is false whatever the IDs are, the controls write their own DOM values, and typing goes through value-accessor listeners that mark the view |
playlist |
| [x] | libs/portal/stalker/feature/src/lib/stalker-live-stream-layout/stalker-live-stream-layout.component.ts (favorites load) |
favorites Map filled in a subscribe without markForCheck; the component is OnPush already, so this is a latent bug today |
portal |
| [x] | libs/portal/xtream/feature/src/lib/portal-channels-list/portal-channels-list.component.ts (favorites load) |
same pattern; the neighbouring favoriteMarks.changes$ handler does call markForCheck |
portal |
| [x] | same file, programme dialog afterClosed |
deletes from epgPrograms/currentProgramsProgress after await without marking |
portal |
| [x] | apps/web/src/app/settings/settings-backup.facade.ts (backup import) |
change listener on a detached file input → hydrateFromStore(); section templates read form().value.theme/coverSize; each section now marks itself on its form's events (markSectionForCheckOnFormEvents), which settings.component.form.spec.ts guards without a forced render |
apps/web |
| [x] | libs/ui/epg/src/lib/epg-guide/epg-guide.component.ts (jump to now, keyboard focus) |
afterNextRender registered from CDK/RxJS callbacks; zone.js followed them with a tick, zoneless schedules no render, so the guide opened at midnight. It now marks itself when it registers the hook. Found by epg-guide.e2e.ts on the zoneless build |
flag |
| [ ] | libs/ui/remote-control/src/lib/remote-control/remote-control.component.ts |
plain isLoading/error/status written after await and from a 2 s setInterval |
only if apps/remote-control-web goes zoneless |
Explicit zone and change-detector calls
They keep working under zoneless (NgZone becomes NoopNgZone, so run
and runOutsideAngular just call through). Remove them in the flip PR, not
before: with zone.js on they still matter.
apps/web/src/app/settings/settings-unload-guard.service.ts: twozone.runcalls around the window-close dialog (IPConWindowCloseRequestedandbeforeunload).libs/ui/playback/src/lib/embedded-mpv-player/embedded-mpv-session-controller.ts:runOutsideAngular(() => setInterval(...))for the position poll;embedded-mpv-session-controller.position.spec.tsasserts the call and changes with it.libs/workspace/dashboard/data-access/src/lib/dashboard-data.service.ts: 18ngZone.run(() => signal.set(...))calls, all redundant around signal writes.libs/workspace/dashboard/data-access/src/lib/dashboard-source-expiry.service.ts: onengZone.runaround a signal update.ChangeDetectorRefinstalker-live-stream-layout.component.ts(4 ×markForCheck, 1 ×detectChangesbefore measuring a row) andportal-channels-list.component.ts(3 ×markForCheck, 2 ×detectChanges): correct under zoneless; replace the Maps with signals in the portal PR if it stays small.
Checked and signal-safe
No change needed; recorded so the flag PR knows where to look if a journey regresses. Embedded MPV and external players are the riskiest paths because their events arrive over IPC.
- IPC listeners (17 registrations): app update status, external player sessions, window close and window state, player errors, playlist open requests, embedded MPV sessions, playback history gate, downloads, recordings, playlist refresh, DB operation and save progress, EPG progress, playback position updates, channel change and remote-control commands. All write signals, signal stores or NgRx, or have no UI state.
- Player libraries (video.js, mpegts.js, hls.js, artplayer, shaka, native
<video>): callbacks bump signals in the control adapters or emit outputs whose parent handlers write signals. - Observers (13 Intersection/Resize/Mutation observers) and document
and window listeners (~40): signals or DOM only.
@HostListenerbindings are Angular listeners and mark their view. - Timers (~130
setTimeout/setInterval/rAF/queueMicrotask): all write signals, touch the DOM or focus, or have no UI state, apart from the two in the table above. - Dialogs and snackbars (20
afterClosed/onActionsites): signals, stores, outputs or navigation, apart from the one in the table above. - No production code uses
NgZone.onStable,onMicrotaskEmpty,isStable,ApplicationRef.tick(),Zone.currentorngDoCheck.
Build, tests and runtime details
provideServiceWorker(..., { registrationStrategy: 'registerWhenStable:30000' }): under zoneless "stable" means no pending tasks. The 30 s bound still registers the worker; check the PWA build in the flag PR.change-detection-tick-counter.tswrapsApplicationRef._tick, which the zoneless scheduler also calls, so the counters stay comparable.- Specs that need zone.js:
fakeAsyncinplaylist-switcher.component.spec.tsandstalker-live-navigation.spec.ts,waitForAsyncin 13 files. They keepzone.js/testinguntil rewritten; removing zone.js from the build polyfills does not affect them. - Unreferenced leftovers to delete in the flip PR:
apps/web/src/polyfills.ts,apps/web/src/polyfills-test.ts,apps/web/src/setup-jest.ts(no project, tsconfig or Jest config uses them).
Zoneless flag
app.config.ts takes its change-detection providers from
apps/web/src/environments/change-detection.providers.ts
(provideZoneChangeDetection({ eventCoalescing: true })). The
electron-performance-zoneless and electron-e2e-zoneless web
configurations are their base configuration plus one fileReplacements
swap to change-detection.providers.zoneless.ts
(provideZonelessChangeDetection()); a test in
performance-build-config.spec.ts pins that and refuses the swap in any
other configuration. zone.js stays in the polyfills, so these builds log
NG0914 in dev mode and nothing schedules through the zone. The Electron app
loads the renderer from dist/apps/web, so rebuilding only the web app
switches an existing Electron build:
pnpm nx run electron-backend:build-performance # or build-e2e
pnpm nx run web:build:electron-performance-zoneless # or electron-e2e-zoneless
cd apps/electron-backend-e2e
../../node_modules/.bin/playwright test --config=playwright.journeys.config.ts
../../node_modules/.bin/playwright test --grep-invert packaged
Do not run pnpm run perf:journeys or pnpm nx run electron-backend-e2e:e2e
afterwards: their build dependencies restore the zone.js renderer.
First measurement (macOS, 2026-10-04, the six OnPush PRs merged locally on the flag branch; the same integration build measured with the flag off and on, five iterations each):
| Counter | flag off | flag on |
|---|---|---|
renderer.cdTicksToFirstCard |
22, 20, 22, 21, 21 | 7, 7, 7, 7, 7 |
renderer.cdTicksIdle30s |
4, 4, 4, 4, 4 | 3, 3, 3, 3, 3 |
renderer.cdTicksToFirstPage |
22 (all) | 8 (all) |
renderer.cdTicksToPlaying |
16, 15, 15, 17, 15 | 6, 8, 10, 10, 7 |
| DOM mutations J1 / J2 / J3 | 553 / 1,603 / 6,182 | 553 / 1,603 / 6,182 (one J3 iteration 6,199, as on master) |
spawnToFirstCardMs p50 |
3,071 | 828 |
clickToFirstPageMs p50 |
82.8 | 80.4 |
clickToLoadedMetadataMs / clickToPlayingMs p50 |
94.8 / 268.7 | 158.3 / 409.3 |
J1 and J2 tick counts become deterministic without the zone.js one-tick
race, and the DOM mutations are unchanged, so nothing renders differently.
J3's tick count still varies with player events and its wall-clock
numbers rose locally; the machine was shared with other runs (load 26 to 58
during these two runs, master itself read 363.8 ms clickToPlayingMs p50
earlier the same day), so judge J3 on the CI runner before the flip.
Electron E2E suite on electron-e2e-zoneless (all specs except the
packaged frame-copy ones): 203 passed, 7 skipped, 3 failed. epg-guide
failed on every run and is fixed above; playlist-auto-refresh passed on
--repeat-each=2; dash-clearkey "reopens from recent and favorites" is the
known local flake (it fails as often on master). The IPC-driven paths
passed zoneless: external-player launch states and the MPV/VLC DASH
fallbacks in dash-clearkey, the MPV double-click gate in settings,
remote-control, picture-in-picture and stream-info. Their state reaches
the renderer over IPC into signals and never ran in the zone. Embedded MPV
playback itself is covered only by the packaged frame-copy E2E, which these
runs left out; run it on a packaged zoneless build before the flip.
Measuring a PR
Build electron-performance and run the journeys as described in
performance journeys, then paste
renderer.cdTicksToFirstCard, renderer.cdTicksIdle30s,
renderer.cdTicksToFirstPage and renderer.cdTicksToPlaying before and
after. While zone.js is on, removing Eager does not change the number of
ticks, only the work per tick; expect the counters to stay put until the flag
PR and the template work (DOM mutations, profile time) to drop.