x15904151985/iptvnator

0 Fork 0

mirror of https://github.com/4gray/iptvnator.git synced 2026-10-08 17:06:15 -08:00

Files

T

4grayandClaude Fable 5 4d63f76407 perf(stalker): skip wasted series-seasons request for non-series items (#1241 )

`setSelectedItem` mirrored every selection's id into `selectedSerialId`, and
`serialSeasonsResource` fires a `get_ordered_list&type=series&movie_id=<id>`
portal request on every change of that id. Opening any Stalker detail page —
plain VOD, vclub items with embedded `series[]` (whose result
`mapRegularSeriesSeasons` discards), Ministra `is_series` items, and ITV
channel clicks — therefore issued a pointless request, on every entry path
(browse, favorites, recent, dashboard, search).

Set `selectedSerialId` only when `selectedContentType === 'series'`, clearing
it otherwise. The gate is deliberately on content type alone, not item shape:
under the `series` content type `serialSeasonsResource` is the only episode
source (the detail templates render `<app-stalker-series-view />` with no
`vodWithSeries` input, and `isVodSeries()` requires content type `vod`), so
gating on `is_series`/`series[]` would leave a series-section item carrying
either field with a silently empty episode list.

Adds selection-state and request-level regression coverage, and corrects a
stale invariant in the Stalker architecture docs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-07-25 16:54:30 +02:00

6.3 KiB

Raw Blame History

Stalker Store API Baseline

This is the compatibility baseline for refactoring libs/portal/stalker/data-access/src/lib/stalker.store.ts.

Goal: keep this public surface stable while splitting to feature stores.

Source of Truth

Store implementation: libs/portal/stalker/data-access/src/lib/stalker.store.ts
Baseline created on current branch state before feature-store extraction.

Public State Signals

Direct signal properties currently exposed by signalStore:

selectedContentType: 'vod' | 'itv' | 'radio' | 'series'
selectedCategoryId: string | null | undefined
selectedVodId: string | undefined
selectedSerialId: string | undefined
selectedItvId: string | undefined
limit: number
page: number
searchPhrase: string
currentPlaylist: PlaylistMeta | undefined
totalCount: number
selectedItem: StalkerVodSource | null | undefined
vodCategories: StalkerCategoryItem[]
seriesCategories: StalkerCategoryItem[]
itvCategories: StalkerCategoryItem[]
radioCategories: StalkerCategoryItem[]
hasMoreChannels: boolean
itvChannels: StalkerItvChannel[]
radioChannels: StalkerItvChannel[]
vodSeriesSeasons: StalkerVodSeriesSeason[]
vodSeriesEpisodes: StalkerVodSeriesEpisode[]
selectedVodSeriesSeasonId: string | undefined

Public Computed Selectors

getTotalPages: number
getPaginatedContent: StalkerContentItem[]
isPaginatedContentLoading: boolean
isPaginatedContentFailed: unknown
getSerialSeasonsResource: StalkerSeason[]
isSerialSeasonsLoading: boolean
getVodSeriesSeasonsResource: StalkerVodSeriesSeason[]
isVodSeriesSeasonsLoading: boolean
getCategoryResource: StalkerCategoryItem[]
isCategoryResourceLoading: boolean
isCategoryResourceFailed: unknown
getSelectedCategoryName: string

Exposed Resources/Props

These are currently reachable on the store object and used internally by computed selectors:

getCategoryResource (computed selector with stable array output)
categoryResource (internal resource)
getContentResource (resource)
serialSeasonsResource (resource)
vodSeriesSeasonsResource (resource)
makeStalkerRequest(...)

During refactor:

Keep compatibility for external callers that may read these directly.
If moved/renamed internally, provide facade aliases.

Public Methods (Compatibility Contract)

setSelectedContentType(type: 'vod' | 'itv' | 'radio' | 'series'): void
setSelectedCategory(id: string | number | null): void
setSelectedSerialId(id: string): void
setSelectedVodId(id: string): void
setSelectedItvId(id: string): void
setLimit(limit: number): void
setPage(page: number): void
setCurrentPlaylist(playlist: PlaylistMeta | undefined): Promise<void>
setSelectedItem(selectedItem: StalkerVodSource | null | undefined): void
clearSelectedItem(): void
setCategories(type: 'vod' | 'series' | 'itv' | 'radio', categories: StalkerCategoryItem[]): void
resetCategories(): void
setItvChannels(channels: StalkerItvChannel[]): void
setRadioChannels(channels: StalkerItvChannel[]): void
setSearchPhrase(phrase: string): void
fetchVodSeriesEpisodes(videoId: string, seasonId: string): Promise<StalkerVodSeriesEpisode[]>
getSelectedCategory(): { id: string | number; name: string; type: 'vod' | 'itv' | 'radio' | 'series' } Backed by withComputed for compatibility, not by withMethods.
fetchLinkToPlay(portalUrl: string, macAddress: string, cmd: string, series?: number): Promise<string>
getExpireDate(): Promise<string>
resolveItvPlayback(item: StalkerPortalItem): Promise<ResolvedPortalPlayback>
resolveRadioPlayback(item: StalkerPortalItem): Promise<ResolvedPortalPlayback>
addToFavorites(item: any, onDone?: () => void): void
removeFromFavorites(favoriteId: string, onDone?: () => void): void
fetchMovieFileId(movieId: string): Promise<string | null>
createLinkToPlayVod(cmd?: string, title?: string, thumbnail?: string, episodeNum?: number, episodeId?: number, startTime?: number): Promise<void>
addToRecentlyViewed(item: any): void
removeFromRecentlyViewed(itemId: number, onComplete?: () => void): void
fetchChannelEpg(channelId: number | string, size?: number): Promise<EpgItem[]>

Current Consumers (Observed)

Top observed store API usage in app code:

currentPlaylist (16 references)
setSelectedContentType (9)
selectedItem (9)
setSelectedItem (7)
setSelectedCategory (6)
createLinkToPlayVod (6)
removeFromFavorites (5)
setPage (4)
addToFavorites (4)
fetchChannelEpg (3)
plus lower-frequency calls for paging/resources/series/recent.

Consumer directories sampled:

libs/portal/stalker/**
libs/portal/xtream/feature/**
libs/portal/catalog/feature/**
libs/ui/components/**

Invariants to Preserve During Refactor

Selection IDs (selectedVodId, selectedItvId) are synchronized in setSelectedItem.
selectedSerialId is set only when selectedContentType is series, and is cleared for every other content type. serialSeasonsResource fires a get_ordered_list&type=series portal request on each change of that id, and it is the only episode source for a series selection — while VOD-context shapes (embedded series[], Ministra is_series) resolve their episodes elsewhere, so carrying the id there only wastes a request. The gate must stay on content type alone: gating it on item shape would leave a series-section item that happens to carry is_series/series[] with an empty episode list.
setSelectedCategory(...) resets page to 0.
getPaginatedContent() and getCategoryResource() always return arrays, even when the underlying request fails.
Radio stores stations separately in radioChannels and falls back to a synthetic all-radio category when a portal does not support radio category responses.
Request failures must surface through isPaginatedContentFailed() and isCategoryResourceFailed() rather than resource reads that throw.
createLinkToPlayVod(...) continues to:
- support episode playback metadata
- append recently viewed
- preserve external player payload shape
Full-portal auth path continues through StalkerSessionService.
Non-auth/simple path continues through DataService.sendIpcEvent(STALKER_REQUEST, ...).
Resource-driven loading signals preserve existing names.

6.3 KiB Raw Blame History