Files
iptvnator/apps/electron-backend-e2e/src/performance/database-worker-post-gc-selection.spec.ts
T
4grayandClaude Opus 5.5 078b91bfdf test(perf): type-check the whole electron-backend-e2e project (#1869)
* test(e2e): fix type errors in four Electron E2E specs

- category-management: the poll's message and 15 s timeout were passed to
  toBe(), which takes one argument, so the poll ran with the default 10 s
  timeout and message. Pass them to expect.poll().
- settings: evaluate<void, HTMLVideoElement> set the argument type, not the
  element type; type the callback parameter instead.
- remote-control: keep the poll callback's writes visible to the return and
  fail with a clear error instead of casting null.
- downloads: read the dataset key through its index signature.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(perf): fix type errors in the benchmark harness

None of these changes behaviour for a capture the harness produces today:

- cancellation report: a null playlist id on the request record now means
  unknown, like undefined, instead of matching only null DB records.
- main capture: type the worker transport map so its unavailable-reason
  literals stay narrow.
- worker request performance: a parsed capture carries non-null work
  timestamps; only the unavailable fallback reports null.
- Xtream iteration: hand the teardown closure the narrowed app and data
  directory.
- Xtream exact schema: return early when the identity is not an exact
  record instead of re-checking it three times.
- Xtream assembly: reject an unpainted UI explicitly; the null-to-0
  comparison already rejected it.
- Xtream scenario driver: drop the always-null cancellation observer from
  prepare; trigger() installs it.
- Electron process lifecycle: type the child process by the exit
  subscription it uses, so a test double need not return a ChildProcess.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(perf): fix type errors in the benchmark harness specs

The dynamically imported helpers were checked with
assert.equal(typeof fn, 'function'), which does not narrow, so later calls
used fn?.(). assert.ok(typeof fn === 'function') narrows them. The rest
types fixtures by the module under test, keeps closure-assigned callbacks
visible after their callbacks run, and narrows nullable fixture values.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(perf): type-check the whole electron-backend-e2e project

Widen the spec config's include from the journey harness to src/**/*.ts
and the root Playwright configs, with no baseline or ignore list, and
update the validation map and the journey checklist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(perf): build a complete renderer fixture in the request-performance spec

The fixture was cast through unknown, so the type check accepted an
incomplete RendererCaptureMetrics. Fill every required field with neutral
values; the summary reads only the probe arrays and heap fields.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-10 14:33:15 +02:00

146 lines
4.1 KiB
TypeScript

/* eslint-disable playwright/expect-expect -- These are Node assertion-based performance contract tests. */
import assert from 'node:assert/strict';
import test from 'node:test';
type WorkerKind = 'database.worker' | 'playlist-refresh.worker';
interface TestWorkerRecord {
readonly captureGeneration: number | null;
readonly finalized: boolean;
readonly kind: WorkerKind;
readonly ordinal: number;
readonly pendingCount: number;
readonly sampleTimer: object | null;
}
type SelectionReason =
| 'database-worker-missing'
| 'database-worker-not-idle'
| 'multiple-database-workers';
interface Selection<T> {
readonly selected: T | null;
readonly unavailableReason: SelectionReason | null;
}
type Selector = <T extends TestWorkerRecord>(
records: readonly T[],
activeGeneration: number
) => Selection<T>;
interface SelectionModule {
createDatabaseWorkerPostGcSelectionApi?: () => {
readonly select: Selector;
};
}
const selectionModulePromise = import(
new URL('./database-worker-post-gc-selection.ts', import.meta.url).href
)
.then((module) => module as SelectionModule)
.catch(() => null);
function workerRecord(
ordinal: number,
overrides: Partial<TestWorkerRecord> = {}
): TestWorkerRecord {
return {
captureGeneration: 7,
finalized: true,
kind: 'database.worker',
ordinal,
pendingCount: 0,
sampleTimer: null,
...overrides,
};
}
async function restoreSerializableSelector(): Promise<Selector> {
const module = await selectionModulePromise;
assert.ok(module, 'database worker post-GC selector module must exist');
const factory = module.createDatabaseWorkerPostGcSelectionApi;
assert.ok(typeof factory === 'function');
const source = factory.toString();
assert.doesNotMatch(source, /__name/);
const restoredFactory = Function(
`"use strict"; return (${source});`
)() as () => {
readonly select: Selector;
};
return restoredFactory().select;
}
test('selects the only current-generation database worker independently of sampling and finalization state', async () => {
const select = await restoreSerializableSelector();
const currentDatabase = workerRecord(4, {
finalized: true,
sampleTimer: null,
});
const previousDatabase = workerRecord(1, {
captureGeneration: 6,
finalized: false,
sampleTimer: {},
});
const currentPlaylist = workerRecord(2, {
finalized: false,
kind: 'playlist-refresh.worker',
sampleTimer: {},
});
const selection = select(
[previousDatabase, currentPlaylist, currentDatabase],
7
);
assert.equal(selection.selected, currentDatabase);
assert.deepEqual(selection, {
selected: currentDatabase,
unavailableReason: null,
});
});
test('reports a missing database worker after ignoring playlists and previous generations', async () => {
const select = await restoreSerializableSelector();
assert.deepEqual(
select(
[
workerRecord(1, { captureGeneration: 6 }),
workerRecord(2, { kind: 'playlist-refresh.worker' }),
],
7
),
{
selected: null,
unavailableReason: 'database-worker-missing',
}
);
});
test('fails closed for multiple current-generation database workers instead of taking the first', async () => {
const select = await restoreSerializableSelector();
const first = workerRecord(1, {
finalized: false,
sampleTimer: {},
});
const second = workerRecord(2, {
finalized: true,
sampleTimer: null,
});
assert.deepEqual(select([first, second], 7), {
selected: null,
unavailableReason: 'multiple-database-workers',
});
});
test('fails closed while the only current-generation database worker is not idle', async () => {
const select = await restoreSerializableSelector();
assert.deepEqual(select([workerRecord(3, { pendingCount: 2 })], 7), {
selected: null,
unavailableReason: 'database-worker-not-idle',
});
});