mirror of
https://github.com/4gray/iptvnator.git
synced 2026-10-13 20:56:19 -08:00
4grayandClaude Opus 5.5
565becf6dd
With the lookup now asynchronous, an external player launched (or the Linux embedded MPV support check, which runs and caches a bare `mpv --version`) within the first seconds could see the inherited PATH. The OPEN_MPV_PLAYER / OPEN_VLC_PLAYER handlers and every embedded MPV handler now await waitForLoginShellPath() (settled lookup, at most 10 s, immediate on Windows), restoring the guarantee the blocking lookup gave. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
92 lines
3.2 KiB
TypeScript
92 lines
3.2 KiB
TypeScript
import { traceStartupPhase } from '../services/debug-trace';
|
|
|
|
/**
|
|
* Update process.env.PATH from the user's interactive login shell so that
|
|
* spawned external players (MPV/VLC) can be resolved by binary name when the
|
|
* app was started from Finder or a desktop launcher.
|
|
*
|
|
* The shell (`$SHELL -ilc env`) starts asynchronously. Its start-up cost
|
|
* depends on the user's shell profile and was about 1-2 s with a typical
|
|
* zsh setup; the synchronous `fix-path` used before blocked the main thread
|
|
* for all of it, right when the database worker's `ready` message and the
|
|
* renderer's first IPC calls were waiting, which delayed the first card of
|
|
* the launch journey by the same amount. The resulting PATH, and the
|
|
* fallback when the shell reports none, are the ones `fix-path` 5 produced.
|
|
*
|
|
* Runs after window creation and IPC handler registration. Idempotent:
|
|
* subsequent calls are no-ops. shell-path is imported here, on demand, so
|
|
* its module evaluation stays off the launch path as well.
|
|
*
|
|
* Handlers that spawn a binary by bare name (external players, the Linux
|
|
* `mpv --version` check of embedded MPV) await `waitForLoginShellPath()`
|
|
* first, so they see the same PATH the blocking lookup guaranteed.
|
|
*/
|
|
let loginShellPathScheduled = false;
|
|
let settleLoginShellPath: () => void = () => undefined;
|
|
const loginShellPathSettled: Promise<void> =
|
|
process.platform === 'win32'
|
|
? Promise.resolve()
|
|
: new Promise((resolve) => {
|
|
settleLoginShellPath = resolve;
|
|
});
|
|
|
|
/** Upper bound for a waiting spawn when the login shell never returns. */
|
|
export const LOGIN_SHELL_PATH_WAIT_LIMIT_MS = 10_000;
|
|
|
|
/**
|
|
* Resolves once the login shell PATH lookup has finished (successfully or
|
|
* not), at the latest after `limitMs`; immediately on Windows.
|
|
*/
|
|
export function waitForLoginShellPath(
|
|
limitMs = LOGIN_SHELL_PATH_WAIT_LIMIT_MS
|
|
): Promise<void> {
|
|
let timer: NodeJS.Timeout | undefined;
|
|
const limit = new Promise<void>((resolve) => {
|
|
timer = setTimeout(resolve, limitMs);
|
|
});
|
|
return Promise.race([loginShellPathSettled, limit]).finally(() =>
|
|
clearTimeout(timer)
|
|
);
|
|
}
|
|
|
|
export type ReadLoginShellPath = () => Promise<string | undefined>;
|
|
|
|
const readLoginShellPath: ReadLoginShellPath = async () => {
|
|
const { shellPath } = await import('shell-path');
|
|
return shellPath();
|
|
};
|
|
|
|
export async function hydratePathFromLoginShell(
|
|
readPath: ReadLoginShellPath = readLoginShellPath
|
|
): Promise<void> {
|
|
const shellPath = await readPath();
|
|
process.env.PATH =
|
|
shellPath ||
|
|
[
|
|
'./node_modules/.bin',
|
|
'/.nodebrew/current/bin',
|
|
'/usr/local/bin',
|
|
process.env.PATH,
|
|
].join(':');
|
|
}
|
|
|
|
export function scheduleDeferredFixPath(
|
|
readPath: ReadLoginShellPath = readLoginShellPath
|
|
): void {
|
|
if (loginShellPathScheduled || process.platform === 'win32') {
|
|
return;
|
|
}
|
|
|
|
loginShellPathScheduled = true;
|
|
setImmediate(() => {
|
|
hydratePathFromLoginShell(readPath)
|
|
.then(() => {
|
|
traceStartupPhase('fix-path:done');
|
|
})
|
|
.catch((error) => {
|
|
console.warn('Login shell PATH lookup failed:', error);
|
|
})
|
|
.finally(() => settleLoginShellPath());
|
|
});
|
|
}
|