mirror of
https://github.com/4gray/iptvnator.git
synced 2026-10-09 01:16:15 -08:00
Adds contract-focused regression coverage for the Electron HTTP server, remote-control events, settings events, and managed download paths, and makes Tier A coverage fail closed when instrumentation fails or a runtime-owning production file disappears from a project or from the merged Istanbul report. The old `coverage:ci` exited 0 despite a `Failed to collect coverage` diagnostic: libs/m3u-state/src/lib/effects.ts was simply absent from the merged map. All 30 Tier A reports are now required, the merged map covers 710 files, and effects.ts is reported as 0/159 instead of silently disappearing. Also fixes remote static-file path containment for encoded, malformed, NUL, POSIX and Win32-style traversal inputs, with behavior-preserving testability seams. Statements 69.27% -> 69.54%; http-server.ts 0% -> 90.21%, remote-control.events.ts 0% -> 96.55%, settings.events.ts 59.25% -> 96.29%.
207 lines
6.2 KiB
JavaScript
207 lines
6.2 KiB
JavaScript
#!/usr/bin/env node
|
|
|
|
import { spawn } from 'node:child_process';
|
|
import { existsSync, readFileSync, rmSync } from 'node:fs';
|
|
import path from 'node:path';
|
|
import process from 'node:process';
|
|
|
|
import {
|
|
createCoverageOutputScanner,
|
|
validateProjectCoverage,
|
|
} from './coverage-integrity.mjs';
|
|
|
|
const workspaceRoot = process.cwd();
|
|
const policyPath = path.join(workspaceRoot, 'tools/coverage/coverage-policy.json');
|
|
const policy = JSON.parse(readFileSync(policyPath, 'utf8'));
|
|
const requestedProjects = new Set(
|
|
process.argv
|
|
.slice(2)
|
|
.flatMap((arg) =>
|
|
arg.startsWith('--projects=')
|
|
? arg.slice('--projects='.length).split(',')
|
|
: []
|
|
)
|
|
.map((project) => project.trim())
|
|
.filter(Boolean)
|
|
);
|
|
|
|
const tierAProjects = policy.unitCoverage.tierA.filter(
|
|
(project) => requestedProjects.size === 0 || requestedProjects.has(project.name)
|
|
);
|
|
|
|
if (tierAProjects.length === 0) {
|
|
console.error('No Tier A coverage projects matched the requested filters.');
|
|
process.exit(1);
|
|
}
|
|
|
|
function readProjectJson(project) {
|
|
const projectJsonPath = path.join(workspaceRoot, project.root, 'project.json');
|
|
if (!existsSync(projectJsonPath)) {
|
|
throw new Error(`Missing project.json for ${project.name}: ${projectJsonPath}`);
|
|
}
|
|
|
|
return JSON.parse(readFileSync(projectJsonPath, 'utf8'));
|
|
}
|
|
|
|
function toPosix(filePath) {
|
|
return filePath.split(path.sep).join('/');
|
|
}
|
|
|
|
function coverageDirFor(project, jestRootMode) {
|
|
const workspaceCoverageDir = path.join('coverage', project.root);
|
|
if (jestRootMode === 'project') {
|
|
return toPosix(path.relative(project.root, workspaceCoverageDir));
|
|
}
|
|
|
|
return toPosix(workspaceCoverageDir);
|
|
}
|
|
|
|
function collectCoverageArgs(project, jestRootMode) {
|
|
const sourceGlob =
|
|
jestRootMode === 'project'
|
|
? 'src/**/*.{ts,js,mjs,html}'
|
|
: `${project.sourceRoot}/**/*.{ts,js,mjs,html}`;
|
|
const sourcePrefix =
|
|
jestRootMode === 'project' ? 'src' : project.sourceRoot;
|
|
|
|
return [
|
|
'--coverage',
|
|
`--coverageDirectory=${coverageDirFor(project, jestRootMode)}`,
|
|
`--collectCoverageFrom=${sourceGlob}`,
|
|
`--collectCoverageFrom=!${sourcePrefix}/**/*.{spec,test}.ts`,
|
|
`--collectCoverageFrom=!${sourcePrefix}/**/test-setup.ts`,
|
|
`--collectCoverageFrom=!${sourcePrefix}/**/test-stubs/**`,
|
|
`--collectCoverageFrom=!${sourcePrefix}/**/*.generated.*`,
|
|
`--collectCoverageFrom=!${sourcePrefix}/**/environments/**`,
|
|
`--collectCoverageFrom=!${sourcePrefix}/**/index.ts`,
|
|
];
|
|
}
|
|
|
|
function jestRootModeFor(project) {
|
|
const mode = project.jestRootMode ?? 'workspace';
|
|
if (mode !== 'workspace' && mode !== 'project') {
|
|
throw new Error(
|
|
`Tier A project ${project.name} has unsupported jestRootMode: ${mode}`
|
|
);
|
|
}
|
|
|
|
return mode;
|
|
}
|
|
|
|
function buildNxArgs(project) {
|
|
const projectJson = readProjectJson(project);
|
|
const testTarget = projectJson.targets?.test;
|
|
if (!testTarget) {
|
|
throw new Error(`Tier A project ${project.name} has no test target.`);
|
|
}
|
|
|
|
if (testTarget.executor === '@nx/jest:jest') {
|
|
return [
|
|
'nx',
|
|
'run',
|
|
`${project.name}:test`,
|
|
'--configuration=ci',
|
|
'--codeCoverage',
|
|
`--coverageDirectory=${coverageDirFor(project, 'workspace')}`,
|
|
'--output-style=static',
|
|
];
|
|
}
|
|
|
|
if (testTarget.executor === 'nx:run-commands') {
|
|
const jestRootMode = jestRootModeFor(project);
|
|
|
|
return [
|
|
'nx',
|
|
'run',
|
|
`${project.name}:test`,
|
|
'--output-style=static',
|
|
'--',
|
|
...collectCoverageArgs(project, jestRootMode),
|
|
];
|
|
}
|
|
|
|
throw new Error(
|
|
`Tier A project ${project.name} uses unsupported test executor: ${testTarget.executor}`
|
|
);
|
|
}
|
|
|
|
function spawnCoverage(args, scanner) {
|
|
return new Promise((resolve, reject) => {
|
|
const child = spawn('pnpm', args, {
|
|
cwd: workspaceRoot,
|
|
env: {
|
|
...process.env,
|
|
CI: process.env.CI ?? 'true',
|
|
NX_TASKS_RUNNER_DYNAMIC_OUTPUT: 'false',
|
|
},
|
|
stdio: ['inherit', 'pipe', 'pipe'],
|
|
});
|
|
|
|
child.stdout.on('data', (chunk) => {
|
|
scanner.push(chunk);
|
|
process.stdout.write(chunk);
|
|
});
|
|
child.stderr.on('data', (chunk) => {
|
|
scanner.push(chunk);
|
|
process.stderr.write(chunk);
|
|
});
|
|
child.once('error', reject);
|
|
child.once('close', (code, signal) => {
|
|
resolve({ code, signal });
|
|
});
|
|
});
|
|
}
|
|
|
|
async function collectProjectCoverage(project) {
|
|
const args = buildNxArgs(project);
|
|
console.log(`\n==> Collecting coverage for ${project.name}`);
|
|
console.log(`pnpm ${args.join(' ')}`);
|
|
|
|
const scanner = createCoverageOutputScanner();
|
|
const result = await spawnCoverage(args, scanner);
|
|
let failed = result.code !== 0 || result.signal !== null;
|
|
|
|
if (scanner.collectionFailed) {
|
|
console.error(
|
|
`Coverage collection failed while testing ${project.name}.`
|
|
);
|
|
failed = true;
|
|
}
|
|
|
|
if (failed) {
|
|
return result.code && result.code !== 0 ? result.code : 1;
|
|
}
|
|
|
|
const validation = validateProjectCoverage({
|
|
project,
|
|
workspaceRoot,
|
|
});
|
|
for (const error of validation.errors) {
|
|
console.error(`Error: ${error}`);
|
|
}
|
|
|
|
return validation.errors.length === 0 ? 0 : 1;
|
|
}
|
|
|
|
for (const project of tierAProjects) {
|
|
const coverageDir = path.join(workspaceRoot, 'coverage', project.root);
|
|
rmSync(coverageDir, { recursive: true, force: true });
|
|
}
|
|
|
|
if (requestedProjects.size === 0) {
|
|
for (const project of [...policy.unitCoverage.tierB, ...policy.unitCoverage.tierC]) {
|
|
if (!project.root) {
|
|
continue;
|
|
}
|
|
const coverageDir = path.join(workspaceRoot, 'coverage', project.root);
|
|
rmSync(coverageDir, { recursive: true, force: true });
|
|
}
|
|
}
|
|
|
|
for (const project of tierAProjects) {
|
|
const status = await collectProjectCoverage(project);
|
|
if (status !== 0) {
|
|
process.exit(status);
|
|
}
|
|
}
|