Files
iptvnator/libs/portal/downloads/feature/src/lib/download-manager-actions.service.ts
T
4grayandClaude Opus 5.5 082c56608b fix(ui): destructive confirmations, verb labels and provider icons
Confirmations: ConfirmDialogData.confirmLabel is required, so no dialog can
fall back to "Yes"/"No"; the dismiss defaults to "Cancel" and
`tone: 'destructive'` styles the confirm with .app-destructive-button. Every
caller names its action ("Remove playlist", "Clear", "Refresh playlist",
"Cancel download" with a "Close" dismiss). The confirm button has the
confirm-dialog-confirm test id and drops its no-op color="primary".

The no-op `warn` color input becomes .app-destructive-button on the EPG
mapping, playlist item, error view, EPG/reset settings, delete-all and source
cleanup buttons, and on the unsaved-changes dialog's Discard.

Provider icons come from SOURCE_TYPE_ICONS in shared/interfaces (Xtream
cloud, Stalker cast, M3U playlist_play / link / description / subject) in the
add dialog, auto-import, empty state, playlist switcher, playlist rows,
dashboard source rail, command palette, Sources filters and both reset
summaries. Stalker no longer borrows the Dashboard icon, and Xtream no longer
shares a glyph with M3U URL playlists.

The playlist error view removed a playlist through the stale
PlaylistActions.removePlaylist: it dropped the playlist from state before the
delete ran, swallowed failures, skipped the source activity guard and showed
no toast. It now uses PlaylistDeleteActionService like every other removal,
commits only a completed delete, toasts and goes home. The unused action and
its effect are removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 18:59:23 +02:00

241 lines
8.2 KiB
TypeScript

import { Injectable, inject, signal } from '@angular/core';
import { MatSnackBar } from '@angular/material/snack-bar';
import { TranslateService } from '@ngx-translate/core';
import { type DownloadItem, DownloadsService } from '@iptvnator/services';
import { DialogService } from '@iptvnator/ui/components';
import type {
DownloadActionResult,
DownloadItemAction,
} from './download-actions';
interface DownloadOperationResult {
readonly success: boolean;
readonly error?: string;
readonly recoveryPath?: string;
}
@Injectable()
export class DownloadManagerActionsService {
private readonly downloads = inject(DownloadsService);
private readonly dialogs = inject(DialogService);
private readonly translate = inject(TranslateService);
private readonly snackBar = inject(MatSnackBar);
readonly pendingIds = signal<ReadonlySet<number>>(new Set());
readonly isClearing = signal(false);
async run(action: DownloadItemAction): Promise<DownloadActionResult> {
const { item, type } = action;
if (this.pendingIds().has(item.id)) {
return 'ignored';
}
if (type === 'remove') {
this.confirmRemove(item);
return 'ignored';
}
if (type === 'copy-url') {
return this.copyUrl(item);
}
if (type === 'play' || type === 'reveal') {
return this.runFileAction(type, item);
}
const operations = {
cancel: () => this.downloads.cancelDownload(item.id),
pause: () => this.downloads.pauseDownload(item.id),
redownload: () => this.downloads.redownloadMissing(item.id),
resume: () => this.downloads.resumeDownload(item.id),
retry: () => this.downloads.retryDownload(item.id),
};
return this.withPending(item.id, operations[type]);
}
clearFinished(scopePlaylistId?: string): void {
this.dialogs.openConfirmDialog({
title: this.translate.instant(
'DOWNLOADS.CLEAR_FINISHED_DIALOG.TITLE'
),
message: this.translate.instant(
'DOWNLOADS.CLEAR_FINISHED_DIALOG.MESSAGE'
),
confirmLabel: this.translate.instant('DOWNLOADS.CLEAR_FINISHED'),
tone: 'destructive',
onConfirm: () => this.performClearFinished(scopePlaylistId),
});
}
showActionError(error?: string): void {
const base = this.translate.instant('DOWNLOADS.ACTION_FAILED');
this.snackBar.open(error ? `${base}: ${error}` : base, undefined, {
duration: 4000,
horizontalPosition: 'start',
});
}
showMessage(key: string, duration: number): void {
this.snackBar.open(this.translate.instant(key), undefined, {
duration,
horizontalPosition: 'start',
});
}
private confirmRemove(item: DownloadItem): void {
const dialogKey =
item.status === 'completed'
? 'DOWNLOADS.REMOVE_COMPLETED_DIALOG'
: 'DOWNLOADS.REMOVE_PARTIAL_DIALOG';
this.dialogs.openConfirmDialog({
title: this.translate.instant(`${dialogKey}.TITLE`),
message: this.translate.instant(`${dialogKey}.MESSAGE`),
confirmLabel: this.translate.instant(
'DOWNLOADS.REMOVE_FROM_MANAGER'
),
tone: 'destructive',
onConfirm: () =>
this.withPending(item.id, () =>
this.downloads.removeDownload(item.id)
),
});
}
private async performClearFinished(
scopePlaylistId?: string
): Promise<void> {
if (this.isClearing()) {
return;
}
this.isClearing.set(true);
try {
const result = await this.downloads.clearCompleted(scopePlaylistId);
if (!result.success) {
if (result.recoveryPath) this.showRecovery(result.recoveryPath);
else this.showActionError();
}
} catch (error) {
this.showActionError(
error instanceof Error ? error.message : String(error)
);
} finally {
this.isClearing.set(false);
}
}
private async runFileAction(
type: 'play' | 'reveal',
item: DownloadItem
): Promise<DownloadActionResult> {
const filePath = item.filePath;
if (!filePath) {
this.showMessage('DOWNLOADS.FILE_NOT_FOUND', 3000);
return 'file-missing';
}
return this.withPending(
item.id,
() =>
type === 'play'
? this.downloads.playDownload(filePath)
: this.downloads.revealFile(filePath),
async (error) => {
if (error === 'File not found') {
await this.downloads.loadDownloads();
}
this.showFileActionError(error);
},
(error) => (error === 'File not found' ? 'file-missing' : 'failed')
);
}
private async copyUrl(item: DownloadItem): Promise<DownloadActionResult> {
return this.withPending(
item.id,
async () => {
try {
await navigator.clipboard.writeText(item.url);
this.showMessage('DOWNLOADS.URL_COPIED', 2000);
return { success: true };
} catch {
return { success: false };
}
},
() => this.showMessage('DOWNLOADS.URL_COPY_FAILED', 3000)
);
}
private async withPending(
itemId: number,
operation: () => Promise<DownloadOperationResult>,
onFailure: (error?: string) => void | Promise<void> = (error) =>
this.showActionError(error),
failureResult: (error?: string) => DownloadActionResult = () => 'failed'
): Promise<DownloadActionResult> {
if (this.pendingIds().has(itemId)) {
return 'ignored';
}
this.pendingIds.update((ids) => new Set(ids).add(itemId));
try {
let failure: string | undefined;
let failed = false;
try {
const result = await operation();
if (result.recoveryPath) {
this.showRecovery(result.recoveryPath);
return 'failed';
}
failed = !result.success;
failure = result.error;
} catch (error) {
failed = true;
failure =
error instanceof Error ? error.message : String(error);
}
if (failed) {
try {
await onFailure(failure);
} catch (error) {
this.showActionError(
error instanceof Error ? error.message : String(error)
);
}
return failureResult(failure);
}
return 'success';
} finally {
this.pendingIds.update((ids) => {
const next = new Set(ids);
next.delete(itemId);
return next;
});
}
}
private showRecovery(path: string): void {
this.dialogs.openConfirmDialog({
title: this.translate.instant('DOWNLOADS.RECOVERY.TITLE'),
keepOpenOnConfirm: true,
cancelLabel: this.translate.instant('CLOSE'),
width: '600px',
message: this.translate.instant('DOWNLOADS.RECOVERY.MESSAGE', {
path,
}),
confirmLabel: this.translate.instant(
'DOWNLOADS.RECOVERY.COPY_PATH'
),
onConfirm: async () => {
try {
await navigator.clipboard.writeText(path);
} catch {
this.showActionError();
}
},
});
}
private showFileActionError(error?: string): void {
this.showMessage(
error === 'File not found'
? 'DOWNLOADS.FILE_NOT_FOUND'
: 'DOWNLOADS.FILE_ACTION_ERROR',
3000
);
}
}