* perf(web): make the app root and settings components OnPush
Plan item C6 step 3 for apps/web: the fifteen Eager components switch to
OnPush, among them the app root and the update notification panel that
the idle audit found re-rendering on every idle tick. Their template
state is signals from the settings facades, signal inputs and the shared
reactive settings form.
The checklist flagged the backup import, which patches the form from a
detached file input with no template event. A new spec patches only a
value, which changes no form status, and confirms the OnPush general
section still shows the new theme; it guards that path for the zoneless
flag.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(settings): re-render OnPush sections when the form changes outside them
Review follow-ups (Greptile, Codex):
- The settings sections read form values in their templates (selected
theme and cover size, epgField.value, form().value.player), and the
parent changes the form outside their events: Discard and backup import
patch it, the store hydrates it, the EPG file picker sets a control
after an await. Under OnPush the section kept the old selection or EPG
status. Each section now marks itself on its form's events
(markSectionForCheckOnFormEvents).
- The value-only patch test no longer forces detectChanges(); with the
fixture rendering on its own it fails without the marking, and so does
a new test for a control set outside the EPG section.
- The zoneless guard counts only changeDetection metadata outside
comments, so a comment naming the strategy is not an Eager component.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(settings): guard the unsaved-changes bar after a save off the sections
Review follow-up (Codex): Save marks the form pristine after an async
store write, also on Backup, Reset or search, where no form section is
rendered. The OnPush page re-renders anyway because pristine and valid
read the form's state signals; the new test checks that on the Backup
page without forcing a render (it waits for the scheduled one).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: 4gray <fourgray@proton.me>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(settings): make the update-channel check honest and keep release notes fresh
Settings → About mixed two commit models: the channel select applied on
Save while "Check again" ran immediately against the still-saved channel,
so picking Nightly and checking reported "latest version" for Stable under
a select reading Nightly. The status now carries a badge naming the channel
the verdict describes; while the select shows an unsaved other channel the
verdict is dimmed, a hint names both channels, and the check button becomes
"Save and check for <channel> updates", which submits the form — the main
process already re-checks when the saved channel changes. A download in
flight or finished belongs to the previous channel and keeps the plain
check.
"What's new" for a nightly published after the app started failed with a
raw IPC error: each release catalog is a process-lifetime snapshot and a
fully paged list never re-read GitHub. findIndex now reloads the catalog
once when a version is missing, and a newly found update drops every
catalog. The dialog recognises the not-found rejection through the shared
marker text, explains it with the version, and links to the channel's
release list; other failures keep their reason under a localized headline.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(updater): serialize readers of one release catalog
findIndex may rebuild the shared release array while another reader of
the same catalog still holds an index into the old one and dereferences
it after paging further. Every reader now runs through the catalog's
runExclusive queue (getReleaseNotes and the manual-update check), so a
reload can no longer pull the list out from under a navigation.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(settings): attribute a kept download to the channel it was found on
setChannel keeps a download that is running or finished when the saved
channel changes, but status.channel already names the new channel, so the
About badge attributed a Stable download to Nightly and the pending hint
vanished. Every check now stamps status.verdictChannel with the channel it
ran on and setChannel leaves it alone; the badge names that channel, and
while it differs from the saved one a hint says the shown update came from
the other channel and the saved one has not been checked yet.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* refactor(updater): move release-notes reads out of AppUpdateService
AppUpdateReleaseCatalogs (app-update-release-notes.ts) now owns the
per-channel catalogs and both reads the updater performs on them: release
notes with previous/next paging and the newest release for the
manual-install fallback. The service only delegates, shrinking from 610
to 508 lines instead of growing.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* docs(updater): name verdictChannel as the badge's source
The About paragraph still said the badge reads status.channel while the
paragraph below it and the code use status.verdictChannel.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(settings): show the release list, not the earlier release, after a paging failure
A failed Previous/Next keeps the earlier notes for navigation while the
body shows the error, so the dialog's action offered the earlier release
instead of the channel release list. The error is now checked first.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(updater): do not reload the catalog before falling back to latest
A read that falls back to the newest release on a miss (the installed
version's notes, e.g. an unpublished local build) paged the whole list
twice: findIndex reloaded on the miss before index 0 was selected. The
reload is now opt-in per call and off on that path.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
* chore(deps): upgrade Angular to 22.1 and Nx to 23.2
* fix(deps): complete Angular migrations after rebasing on master
* fix(ci): use the Node pin for Windows runtime refresh
* docs(deps): synchronize the workspace-shell Node requirements
* fix(settings): show current release notes
* fix(updater): use app version for local release notes
* fix(settings): constrain release note images
* fix(settings): prefer current notes without updates
