2 Commits

Include renames

Author	SHA1	Message	Date
4gray	8fdac824fd	feat(packaging): ship Linux embedded MPV frame-copy runtime (#1200) ... * docs: design Linux frame-copy packaging * docs: plan Linux frame-copy packaging * feat(packaging): define Linux frame-copy profiles * fix(packaging): reject inherited profile names * feat(embedded-mpv): validate staged Linux runtime * fix(embedded-mpv): require Linux source packages * fix(embedded-mpv): harden Linux runtime staging * feat(embedded-mpv): build LGPL Linux runtime * fix(embedded-mpv): pin Linux runtime inputs * feat(embedded-mpv): build relocatable Linux helper * fix(embedded-mpv): require bundled Linux runtime * fix(embedded-mpv): make Linux runtime portable * feat(packaging): ship Linux frame-copy artifacts * fix(embedded-mpv): verify Linux helper linkage * fix(packaging): enforce Linux frame-copy isolation * fix(embedded-mpv): pin Linux display data * docs(embedded-mpv): document Linux frame-copy packaging * feat(embedded-mpv): probe Linux frame-copy runtime * test(embedded-mpv): smoke packaged Linux frame-copy * docs(embedded-mpv): clarify Linux system runtime baseline * fix(embedded-mpv): harden Linux runtime capability gate * ci: verify Linux frame-copy packages * test(embedded-mpv): harden packaged Linux smoke * test(embedded-mpv): preserve packaged GL mode * test(packaging): harden Linux package probes * fix(embedded-mpv): enable private Snap shared memory * fix(embedded-mpv): sanitize Linux helper environment * fix(packaging): enforce private Snap memory semantics * fix(packaging): reject ambiguous Snap memory metadata * fix(embedded-mpv): prioritize trusted Snap GL * fix(packaging): reject advanced Snap YAML semantics * fix(packaging): reject arbitrary Snap YAML aliases * feat(packaging): ship Linux runtime license notices * docs(embedded-mpv): document Linux runtime distribution * fix(packaging): parse Snap trailing comments safely * fix(release): gate Snap publish on public source release * fix(packaging): strip VCS metadata from source bundle * docs(packaging): clarify Linux source release gate * test(embedded-mpv): smoke missing bundled libmpv * style(embedded-mpv): format final validation inputs * fix(e2e): satisfy fixture index signature typing * fix(ci): declare fontconfig gperf generator * fix(embedded-mpv): hash runtime cache identities * fix(packaging): harden Linux frame-copy delivery * fix(packaging): tighten runtime delivery gates * fix(ci): decouple Linux runtime matrix * fix(packaging): harden Linux frame-copy delivery * fix(packaging): validate Linux frame-copy runtimes * fix(packaging): scope Snap Electron library checks * feat(packaging): ship Linux frame-copy runtimes * fix(packaging): improve Linux runtime smoke diagnostics * fix(packaging): expose bounded helper probe details * test(packaging): trace Snap EGL probe failures * fix(packaging): prefer core22 ABI in Snap helper * fix(packaging): bound helper probe capture * fix(packaging): harden Linux frame-copy releases * fix(packaging): canonicalize libplacebo submodule identity * fix(packaging): make source archive inspection portable * fix(packaging): harden Snap release verification	2026-07-18 17:28:22 +02:00
4grayandClaude Opus 4.8	23ead63b1f	fix(packaging): ship ms so the updater doesn't crash the app (#1103) (#1113) ... * fix(packaging): ship `ms` so the updater doesn't crash the app (#1103) The 0.22 AppImage crashed on launch with "Cannot find module 'ms'" after the desktop updater landed (b1119189). electron-updater requires `debug` -> `ms` unguarded at startup, but the packaged app.asar shipped `debug` without `ms`. Root cause: with pnpm's isolated node-linker, electron-builder 26 uses its PnpmNodeModulesCollector, which builds the bundle from `pnpm list --json`. pnpm deduplicates repeated packages there, so all but one `debug@4.4.3` occurrence report empty `dependencies` — and the collector (unlike the npm collector) has no implicit-dependency recovery, so it drops `ms` entirely. It stayed latent because the only prior `debug` consumer (follow-redirects via axios) guards its require in try/catch; electron-updater is the first packaged module to hit it unguarded. Fix: declare `ms` as a direct dependency so it becomes a top-level, fully-expanded node in the collector's tree and is bundled. This keeps the isolated pnpm layout intact — `node-linker=hoisted` was rejected because it removes `node_modules/.pnpm`, which apps/electron-backend/build-embedded-mpv.js scans to resolve @electron/node-gyp, breaking the native build on every platform. Also add a packaged-asar dependency-closure guard to verify-electron-package-layout.mjs: it audits every package shipped in the archive and fails if any non-optional dependency is missing, so this class of regression is caught in CI. Logic is extracted to a unit-tested module. Verified locally: repackaged app.asar now ships `ms`, the embedded-mpv native build succeeds, and the closure guard reports 0 missing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(packaging): harden asar dependency-closure guard from review findings Addresses review feedback on #1113 plus an adversarial-review finding: - Walk every ancestor directory in resolvePackagedDependency (not just node_modules boundaries) so a dependency hoisted to the archive root resolves for packages under app subdirectories, matching Node's real resolution (Codex review). - Skip dependencies also declared in peerDependencies: host-provided peers (e.g. electron) listed in both fields are not packaging defects (Greptile review). - Fix a silent no-op on Windows: @electron/asar lists entries and resolves extractFile paths with the host separator, so the posix-only matching audited zero packages on the Windows CI leg. Listings are now normalized to posix and lookup paths converted back to the host separator (pathSep is injectable for tests). - Reject vacuous passes structurally: inspectPackagedDependencyClosure now reports packageCount and manifestReadFailures, and the verifier errors when the audit saw no packages or failed to read manifests, so the guard can never silently audit nothing again. Verified: 27 packaging tests pass; the real app.asar audits 235 packages with 0 missing under both posix and simulated win32 IO; hiding `ms` from a win32-shaped listing correctly flags it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-01 23:58:21 +02:00