From fbed100fb04e51505efc894cc5481da86b68028d Mon Sep 17 00:00:00 2001 From: 4gray Date: Sat, 8 Nov 2025 15:27:10 +0100 Subject: [PATCH] ci: make release step create draft prereleases for PRs Update the GitHub release action to mark releases from pull request events as prerelease and to set a safe tag name when the is not triggered by a tag ref. - Set prerelease to true when github.event_name == 'pull_request' so draft releases created during PR workflows are marked as prereleases. - Use the tag name from github.ref_name when the workflow is triggered by a tag; otherwise generate a deterministic test tag "test-" to avoid using an invalid or empty tag name. This prevents accidental full releases from PR runs and ensures the action always has a valid tag_name value. --- .github/workflows/build-and-make.yaml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-and-make.yaml b/.github/workflows/build-and-make.yaml index 6c61ead2c..acda077b8 100644 --- a/.github/workflows/build-and-make.yaml +++ b/.github/workflows/build-and-make.yaml @@ -110,11 +110,20 @@ jobs: uses: softprops/action-gh-release@v2 with: draft: true - prerelease: false + prerelease: ${{ github.event_name == 'pull_request' }} name: Release v${{ steps.package-version.outputs.version }} - tag_name: ${{ github.ref_name }} + tag_name: ${{ startsWith(github.ref, 'refs/tags/') && github.ref_name || format('test-{0}', github.sha) }} generate_release_notes: true files: | - artifacts/**/* + artifacts/macos-artifacts/*.dmg + artifacts/macos-artifacts/*.zip + artifacts/linux-artifacts/*.AppImage + artifacts/linux-artifacts/*.deb + artifacts/linux-artifacts/*.rpm + artifacts/linux-artifacts/*.snap + artifacts/linux-artifacts/*.tar.gz + artifacts/windows-artifacts/*-setup.exe + artifacts/windows-artifacts/*.msi + artifacts/windows-artifacts/*.zip env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}