mirror of
https://github.com/4gray/iptvnator.git
synced 2026-10-15 21:56:18 -08:00
fix(sources): name the Sources sort group; refit the switcher on resize
Local review on the PR round: - Greptile: the Sources sort menu's radio group had no accessible name, unlike every other menu group (UI guidelines). It is named by its section, "Sort by". - Codex: the switcher popover capped its height once, when it opened, so shrinking the window while it was open left the footer and the lower rows out of reach. A window resize refits the open popover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
e3a4ea7259
commit
ee35951a5e
4 files changed
+48
-2
No files matched your search
+6
-1
@@ -49,7 +49,12 @@
|
||||
class="app-menu"
|
||||
xPosition="before"
|
||||
>
|
||||
<div role="group">
|
||||
<div
|
||||
role="group"
|
||||
[attr.aria-label]="
|
||||
'WORKSPACE.REFINE_SORT_SECTION' | translate
|
||||
"
|
||||
>
|
||||
@for (option of sortOptions; track $index) {
|
||||
<button
|
||||
mat-menu-item
|
||||
|
||||
+4
@@ -293,6 +293,10 @@ describe('WorkspaceSourcesComponent', () => {
|
||||
...Array(7).fill('menuitemradio'),
|
||||
'menuitemcheckbox',
|
||||
]);
|
||||
// The radio group is named by its section, as every menu group is.
|
||||
expect(
|
||||
rows[0].closest('[role="group"]')?.getAttribute('aria-label')
|
||||
).toBe('WORKSPACE.REFINE_SORT_SECTION');
|
||||
expect(rows.map((row) => row.getAttribute('aria-checked'))).toEqual([
|
||||
'true',
|
||||
...Array(7).fill('false'),
|
||||
|
||||
Reference in new issue
Block a user