x15904151985/iptvnator
1
0 Fork 0
mirror of https://github.com/4gray/iptvnator.git synced 2026-10-10 10:06:15 -08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(electron): split external player sessions

Browse Source 
Split the Electron external-player IPC monolith into focused launch-context, playback-request, runtime, MPV session, and VLC session modules. Includes Greptile follow-up fixes for Homebrew Cask VLC path resolution and VLC spawn-error promise handling, with regression coverage.
This commit is contained in:
4gray authored and GitHub committed 2026-05-26 23:15:28 +02:00
1 parent 701cf23299
commit edaa981061
9 files changed
+1955 -1664
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

docs/architecture/embedded-inline-playback.md
+24
View File
@@ -189,6 +189,30 @@ MPV or VLC instance reuse is active and an existing process is reused, subsequen
streams are loaded through MPV IPC or VLC RC commands and new process arguments
are not re-applied until a fresh process starts.
## Electron External Player Ownership
External MPV/VLC integration is split across focused main-process modules:
- `apps/electron-backend/src/app/events/player.events.ts` registers IPC handlers
and settings updates only.
- `apps/electron-backend/src/app/events/external-player-launch-context.ts`
resolves Flatpak spawning, default executable paths, macOS `.app` bundles,
custom argv merging, spawn specs, and reuse decisions.
- `apps/electron-backend/src/app/events/external-player-playback-request.ts`
builds the effective playback request, including Stalker direct-stream fallback
metadata and external-player request headers.
- `apps/electron-backend/src/app/events/external-player-runtime.ts` owns shared
session tracking, trace logging, renderer notifications, playback-position
forwarding, and user-facing start errors.
- `apps/electron-backend/src/app/events/mpv-session.service.ts` owns MPV process,
socket, reuse, cleanup, and progress polling lifecycle.
- `apps/electron-backend/src/app/events/vlc-session.service.ts` owns VLC process,
RC interface, reuse, cleanup, command parsing, and progress polling lifecycle.
Keep player-specific process state in the MPV/VLC session modules. Shared spawn,
request-header, session-registry, and notification helpers belong in the
`external-player-*` modules so IPC registration stays small and reviewable.
## Flatpak External Players
Flatpak cannot execute host-installed `mpv` or `vlc` binaries directly from the sandbox.