mirror of
https://github.com/4gray/iptvnator.git
synced 2026-10-08 17:06:15 -08:00
feat(about): show build commit next to the app version (#1208)
* feat(about): show build commit next to the app version Settings > About now renders "<version> (<short-sha>)" with the full SHA in the tooltip, so bug reports from test and nightly builds identify the exact commit. The commit is injected at CI build time into apps/web/src/environments/build-commit.ts (same placeholder pattern as the TMDB key inject); PR builds use the real head SHA instead of the ephemeral merge commit. Local/dev builds keep the plain version. The semver version itself deliberately stays untouched: a "-sha" suffix would flip electron-updater into prerelease mode and leak into installer/artifact version fields. Requested by WolfganP in #1202. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * style(settings): keep relative import after monorepo alias imports Addresses Greptile feedback on #1208. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(docker): inject build commit into published PWA images The Docker/PWA build path bypassed the Electron workflow's inject step, so published images showed the plain version in About. Pass the commit as a build arg and run the inject script before the PWA build; the script no-ops when BUILD_COMMIT is empty, leaving local docker builds unchanged. Addresses Codex feedback on #1208. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
ec6fc403a3
commit
ec09778f36
11 files changed
+162
-2
No files matched your search
@@ -406,6 +406,14 @@ jobs:
|
||||
TMDB_API_KEY: ${{ secrets.TMDB_API_KEY }}
|
||||
run: node tools/tmdb/inject-tmdb-key.mjs
|
||||
|
||||
- name: Inject build commit
|
||||
# Shows "<version> (<sha>)" in Settings > About so bug reports
|
||||
# from test builds identify the exact commit. PR builds use the
|
||||
# head SHA — github.sha would be the ephemeral merge commit.
|
||||
env:
|
||||
BUILD_COMMIT: ${{ github.event.pull_request.head.sha || github.sha }}
|
||||
run: node tools/build/inject-build-commit.mjs
|
||||
|
||||
- name: Build frontend
|
||||
run: pnpm nx build web --skip-nx-cache
|
||||
|
||||
|
||||
@@ -109,5 +109,7 @@ jobs:
|
||||
push: ${{ steps.docker-meta.outputs.publish == 'true' }}
|
||||
tags: ${{ steps.docker-meta.outputs.tags }}
|
||||
platforms: ${{ steps.docker-meta.outputs.platforms }}
|
||||
build-args: |
|
||||
BUILD_COMMIT=${{ github.event.pull_request.head.sha || github.sha }}
|
||||
cache-from: type=gha
|
||||
cache-to: type=gha,mode=max,ignore-error=true
|
||||
Reference in new issue
Block a user