From e7db9205433e89971fab0d7f66bf9512b0fb7a6e Mon Sep 17 00:00:00 2001 From: 4gray <4gray@users.noreply.github.com> Date: Tue, 12 May 2026 19:49:14 +0200 Subject: [PATCH] fix(settings): clarify external player path hints (#929) * fix(settings): clarify external player path hints * fix(settings): gate external player hints to desktop --- README.md | 2 +- .../settings-playback-section.component.html | 7 +- ...ettings-playback-section.component.spec.ts | 109 +++++++++++++++++- apps/web/src/assets/i18n/ar.json | 5 +- apps/web/src/assets/i18n/ary.json | 5 +- apps/web/src/assets/i18n/by.json | 5 +- apps/web/src/assets/i18n/de.json | 5 +- apps/web/src/assets/i18n/el.json | 5 +- apps/web/src/assets/i18n/en.json | 5 +- apps/web/src/assets/i18n/es.json | 5 +- apps/web/src/assets/i18n/fr.json | 5 +- apps/web/src/assets/i18n/it.json | 5 +- apps/web/src/assets/i18n/ja.json | 5 +- apps/web/src/assets/i18n/ko.json | 5 +- apps/web/src/assets/i18n/nl.json | 5 +- apps/web/src/assets/i18n/pl.json | 5 +- apps/web/src/assets/i18n/pt.json | 5 +- apps/web/src/assets/i18n/ru.json | 5 +- apps/web/src/assets/i18n/tr.json | 5 +- apps/web/src/assets/i18n/zh.json | 5 +- apps/web/src/assets/i18n/zhtw.json | 5 +- .../src/content/blog/v0-21-release-notes.mdx | 2 +- docs/architecture/embedded-inline-playback.md | 6 +- 23 files changed, 174 insertions(+), 42 deletions(-) diff --git a/README.md b/README.md index db5f61c92..a7d1c594b 100644 --- a/README.md +++ b/README.md @@ -24,7 +24,7 @@ The application is a cross-platform, open-source project built with Electron and - M3u and M3u8 playlist support 📺 - Radio playlist support with dedicated audio player 📻 - Xtream Code (XC) and Stalker portal (STB) support -- External player support - MPV, VLC +- External player support - MPV and VLC; macOS accepts `mpv.app` / `VLC.app` bundle paths. IINA can be launched via its executable path on macOS (best-effort: controls and position polling are MPV IPC only) - Add playlists from the file system or remote URLs 📂 - Automatic playlist updates on application startup - Channel search functionality 🔍 diff --git a/apps/web/src/app/settings/settings-playback-section.component.html b/apps/web/src/app/settings/settings-playback-section.component.html index eb1011636..76494e5e6 100644 --- a/apps/web/src/app/settings/settings-playback-section.component.html +++ b/apps/web/src/app/settings/settings-playback-section.component.html @@ -148,13 +148,16 @@ } - @if (form().value.player === 'mpv') { + @if (isDesktop() && form().value.player === 'mpv') {
{{ 'SETTINGS.MPV_PLAYER_PATH_DESCRIPTION' | translate }}
++ {{ 'SETTINGS.MPV_COMPATIBLE_PLAYER_TIP' | translate }} +