From e43d94ded4231df9fd4dc23f0dc21b777815418d Mon Sep 17 00:00:00 2001
From: 4gray <serega05@gmail.com>
Date: Mon, 27 Jul 2026 09:00:56 +0200
Subject: [PATCH] fix(stalker): use canonical serial number key

---
 .../src/lib/stalker-identity-profile.spec.ts  | 28 +++++++++++--------
 .../src/lib/stalker-identity-profile.ts       |  4 +--
 2 files changed, 19 insertions(+), 13 deletions(-)

diff --git a/libs/portal/stalker/protocol/src/lib/stalker-identity-profile.spec.ts b/libs/portal/stalker/protocol/src/lib/stalker-identity-profile.spec.ts
index d595e8ba9..9b7cc5eb4 100644
--- a/libs/portal/stalker/protocol/src/lib/stalker-identity-profile.spec.ts
+++ b/libs/portal/stalker/protocol/src/lib/stalker-identity-profile.spec.ts
@@ -24,6 +24,13 @@ describe('Stalker coherent identity profile', () => {
                 timezone: 'UTC',
             },
         });
+        expect(profile.profileParameters).toEqual({
+            client_type: 'STB',
+            hd: 1,
+            language: 'en',
+            stb_type: 'MAG250',
+            timezone: 'UTC',
+        });
     });
 
     it('omits blank native identity fields instead of inventing values', () => {
@@ -36,15 +43,12 @@ describe('Stalker coherent identity profile', () => {
             signature2: '',
         });
 
-        expect(profile.profileParameters).not.toEqual(
-            expect.objectContaining({
-                device_id: expect.anything(),
-                device_id2: expect.anything(),
-                serial: expect.anything(),
-                signature: expect.anything(),
-                signature2: expect.anything(),
-            })
-        );
+        expect(profile.profileParameters).not.toHaveProperty('device_id');
+        expect(profile.profileParameters).not.toHaveProperty('device_id2');
+        expect(profile.profileParameters).not.toHaveProperty('serial');
+        expect(profile.profileParameters).not.toHaveProperty('signature');
+        expect(profile.profileParameters).not.toHaveProperty('signature2');
+        expect(profile.profileParameters).not.toHaveProperty('sn');
         expect(profile.metrics).toEqual({
             mac: '00:1A:79:00:00:01',
             model: 'MAG250',
@@ -75,10 +79,11 @@ describe('Stalker coherent identity profile', () => {
         expect(profile.profileParameters).toMatchObject({
             device_id: 'Device-One',
             device_id2: 'Device-Two',
-            serial: 'Serial-AbC',
+            sn: 'Serial-AbC',
             signature: 'Sig-One',
             signature2: 'Sig-Two',
         });
+        expect(profile.profileParameters).not.toHaveProperty('serial');
     });
 
     it('normalizes one locale, language, and timezone tuple', () => {
@@ -114,10 +119,11 @@ describe('Stalker coherent identity profile', () => {
             mac: '00:1A:79:00:00:01',
             model: 'MAG250',
             random: 'run-random',
-            serial: 'serial-value',
+            sn: 'serial-value',
             type: 'STB',
             uid: 'actual-uid',
         });
+        expect(profile.metrics).not.toHaveProperty('serial');
     });
 
     it('forwards an explicitly traced firmware tuple without deriving it', () => {
diff --git a/libs/portal/stalker/protocol/src/lib/stalker-identity-profile.ts b/libs/portal/stalker/protocol/src/lib/stalker-identity-profile.ts
index d851b1d13..815e5f96b 100644
--- a/libs/portal/stalker/protocol/src/lib/stalker-identity-profile.ts
+++ b/libs/portal/stalker/protocol/src/lib/stalker-identity-profile.ts
@@ -42,7 +42,7 @@ export function createStalkerIdentityProfile(
         stb_type: 'MAG250',
         timezone,
     };
-    assignPresent(profileParameters, 'serial', serialNumber);
+    assignPresent(profileParameters, 'sn', serialNumber);
     assignPresent(profileParameters, 'device_id', deviceId1);
     assignPresent(profileParameters, 'device_id2', deviceId2);
     assignPresent(profileParameters, 'signature', signature1);
@@ -94,7 +94,7 @@ export function createStalkerIdentityProfile(
         type: 'STB',
     };
     assignPresent(metrics, 'random', handshakeRandom);
-    assignPresent(metrics, 'serial', serialNumber);
+    assignPresent(metrics, 'sn', serialNumber);
     assignPresent(metrics, 'uid', deviceId2);
 
     return {