From dc6665d6d3559af97257c0b347e5c649741c0355 Mon Sep 17 00:00:00 2001 From: 4gray Date: Sun, 26 Jul 2026 19:54:20 +0200 Subject: [PATCH] docs(settings): explain why Electron-side pushes stay in the success path Co-Authored-By: Claude Opus 5 --- apps/web/src/app/settings/settings.component.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/apps/web/src/app/settings/settings.component.ts b/apps/web/src/app/settings/settings.component.ts index d8699ba26..f93a24fac 100644 --- a/apps/web/src/app/settings/settings.component.ts +++ b/apps/web/src/app/settings/settings.component.ts @@ -210,6 +210,13 @@ export class SettingsComponent implements OnInit, OnDestroy { // The store already applied the change in memory, so without // this the save looks successful until the next restart. The // dialog stays open so it can be retried. + // + // The Electron-side pushes in SettingsFormFacade.save() stay in + // the success branch on purpose: main keeps its own copy of the + // player paths and remote-control state, and applying half the + // form while telling the user nothing was saved is worse than + // applying none of it. Once settings live in the main process + // (issue #1273) this split disappears. this.settingsSnackbar.storageFailure('save'); }); }