fix(workspace): defer embedded mpv palette support check

This commit is contained in:
4gray committed 2026-06-28 02:01:38 +02:00
1 parent f7ad17298f
commit d7e7a8abda
6 files changed
+108 -22

No files matched your search

+8 -5
View File
@@ -189,11 +189,14 @@ Command palette behavior is shell-owned but view-extensible:
MPV, MPV, VLC). Each command carries a `requires` flag gating its
visibility: the MPV/VLC ("managed-external") entries are visible only when
`RuntimeCapabilitiesService.supportsManagedExternalPlayers` is true, and the
Embedded MPV ("embedded-mpv") entry is visible only after an async
`window.electron.getEmbeddedMpvSupport()` check resolves to `supported`
(mirroring the Settings dropdown gate). The entry matching the current
`SettingsStore.player()` value is disabled. The new player setting applies
to the next playback session; an existing stream is not re-mounted.
Embedded MPV ("embedded-mpv") entry is visible only after the command
palette lazily preloads an async `window.electron.getEmbeddedMpvSupport()`
check and it resolves to `supported` (mirroring the Settings dropdown gate).
Do not run this Embedded MPV support check from workspace shell bootstrap:
supported desktop builds may load the native addon while resolving
capabilities. The entry matching the current `SettingsStore.player()` value
is disabled. The new player setting applies to the next playback session; an
existing stream is not re-mounted.
Keyboard shortcut help is shell-owned: