From d6da5c778c8f9708497b91b97dc0abe4aa485a39 Mon Sep 17 00:00:00 2001 From: 4gray Date: Sat, 5 Sep 2026 11:51:29 +0200 Subject: [PATCH] test(playback): await changed settings before PiP navigation --- apps/electron-backend-e2e/src/picture-in-picture.e2e.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/electron-backend-e2e/src/picture-in-picture.e2e.ts b/apps/electron-backend-e2e/src/picture-in-picture.e2e.ts index b60e69d0d..4b8d83469 100644 --- a/apps/electron-backend-e2e/src/picture-in-picture.e2e.ts +++ b/apps/electron-backend-e2e/src/picture-in-picture.e2e.ts @@ -41,8 +41,10 @@ for (const player of ['html5', 'videojs', 'artplayer']) { .getByTestId('web-player-shared-controls-setting') .locator('input[type="checkbox"]') .setChecked(sharedControls); - // The default Video.js/shared combination may already be saved. - if (await page.getByTestId('save-settings').isVisible()) { + // A fresh profile defaults to Video.js with shared controls. + // For changed settings, await the save control through the + // helper; an immediate isVisible() can miss Angular rendering it. + if (player !== 'videojs' || !sharedControls) { await saveSettings(page); } const playlistPath = join(dataDir, 'pip.m3u');