From cd331c796cb3654faf73340aa00a09abcd94d5d5 Mon Sep 17 00:00:00 2001 From: 4gray Date: Thu, 14 May 2026 22:29:39 +0200 Subject: [PATCH] fix(playback): narrow declared stream metadata Entire-Checkpoint: f957cd9849e0 --- .../playback-diagnostics.util.spec.ts | 22 +++++++++++++++++-- .../playback-diagnostics.util.ts | 3 --- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/libs/ui/playback/src/lib/playback-diagnostics/playback-diagnostics.util.spec.ts b/libs/ui/playback/src/lib/playback-diagnostics/playback-diagnostics.util.spec.ts index bea76398e..490278b21 100644 --- a/libs/ui/playback/src/lib/playback-diagnostics/playback-diagnostics.util.spec.ts +++ b/libs/ui/playback/src/lib/playback-diagnostics/playback-diagnostics.util.spec.ts @@ -275,12 +275,12 @@ describe('playback diagnostics', () => { ).toBe('m3u8'); expect( getPlaybackMediaExtensionFromUrl( - 'http://portal.example/play/live.php?type=m3u8&stream=123' + 'http://portal.example/play/live.php?container=m3u8&stream=123' ) ).toBe('m3u8'); expect( getPlaybackMediaExtensionFromUrl( - 'http://portal.example/play/live.php?output=ts&stream=123' + 'http://portal.example/play/live.php?ext=ts&stream=123' ) ).toBe('ts'); expect( @@ -303,6 +303,24 @@ describe('playback diagnostics', () => { ).toBe('m3u8'); }); + it('does not infer media extensions from generic type/output query metadata', () => { + expect( + getPlaybackMediaExtensionFromUrl( + 'http://portal.example/play/live.php?type=m3u8&stream=123' + ) + ).toBe(''); + expect( + getPlaybackMediaExtensionFromUrl( + 'http://portal.example/play/live.php?output=ts&stream=123' + ) + ).toBe(''); + expect( + getPlaybackMediaExtensionFromUrl( + 'http://portal.example/play/live.php?format=mpv&stream=123' + ) + ).toBe(''); + }); + it('detects codecs with limited Chromium browser-player support', () => { expect( getLikelyBrowserUnsupportedCodecLabels({ diff --git a/libs/ui/playback/src/lib/playback-diagnostics/playback-diagnostics.util.ts b/libs/ui/playback/src/lib/playback-diagnostics/playback-diagnostics.util.ts index 925bb53aa..caa217f7f 100644 --- a/libs/ui/playback/src/lib/playback-diagnostics/playback-diagnostics.util.ts +++ b/libs/ui/playback/src/lib/playback-diagnostics/playback-diagnostics.util.ts @@ -129,8 +129,6 @@ const DECLARED_MEDIA_EXTENSION_QUERY_KEYS = [ 'ext', 'format', 'container', - 'type', - 'output', ]; const DECLARED_MEDIA_EXTENSION_ALIASES = new Map([ @@ -149,7 +147,6 @@ const DECLARED_MEDIA_EXTENSIONS = new Set([ 'mp3', 'mp4', 'mpd', - 'mpv', 'oga', 'ogg', 'ogv',