From aa92a3b8267bcd18972beb469d383e970c625567 Mon Sep 17 00:00:00 2001 From: 4gray Date: Sat, 4 Jul 2026 14:33:33 +0200 Subject: [PATCH] fix(tmdb): surface TMDB-only VOD score in the rating badge, drop youtube.com from CSP MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Review follow-ups on PR #1123: the Xtream VOD detail badge renders rating_imdb, but the merge wrote the TMDB score only into `rating`, so a TMDB-only score was never displayed (Codex P2) — fill rating_imdb when the provider left it empty, mirroring the Stalker merge. All trailer iframes are normalized to youtube-nocookie.com, so the extra youtube.com frame-src allowance was dead surface (greptile) — removed. Co-Authored-By: Claude Fable 5 --- apps/web/src/index.html | 2 +- libs/services/src/lib/tmdb/tmdb-merge.spec.ts | 14 ++++++++++++++ libs/services/src/lib/tmdb/tmdb-merge.ts | 4 ++++ 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/apps/web/src/index.html b/apps/web/src/index.html index 421f993e5..dc036d8b7 100644 --- a/apps/web/src/index.html +++ b/apps/web/src/index.html @@ -8,7 +8,7 @@ diff --git a/libs/services/src/lib/tmdb/tmdb-merge.spec.ts b/libs/services/src/lib/tmdb/tmdb-merge.spec.ts index 864bf9032..1c8efd1c4 100644 --- a/libs/services/src/lib/tmdb/tmdb-merge.spec.ts +++ b/libs/services/src/lib/tmdb/tmdb-merge.spec.ts @@ -185,6 +185,20 @@ describe('mergeVodInfoWithTmdb', () => { expect(merged.rating).toBe(7); }); + it('fills the displayed rating_imdb field only when the provider left it empty', () => { + const withoutImdb = mergeVodInfoWithTmdb( + providerVodInfo({ rating_imdb: '' }), + tmdbMovie + ); + expect(withoutImdb.rating_imdb).toBe('8.2'); + + const withImdb = mergeVodInfoWithTmdb( + providerVodInfo({ rating_imdb: '7.9' }), + tmdbMovie + ); + expect(withImdb.rating_imdb).toBe('7.9'); + }); + it('fills missing provider release date and country', () => { const info = providerVodInfo({ releasedate: '', country: '' }); const merged = mergeVodInfoWithTmdb(info, tmdbMovie); diff --git a/libs/services/src/lib/tmdb/tmdb-merge.ts b/libs/services/src/lib/tmdb/tmdb-merge.ts index 63798ec86..24a84b626 100644 --- a/libs/services/src/lib/tmdb/tmdb-merge.ts +++ b/libs/services/src/lib/tmdb/tmdb-merge.ts @@ -147,6 +147,10 @@ export function mergeVodInfoWithTmdb( director: prefer(director, info.director), genre: prefer(genre, info.genre), rating: rating ?? info.rating, + // The VOD detail badge renders rating_imdb — fill it when the + // provider left it empty so a TMDB-only score is actually shown + rating_imdb: + info.rating_imdb || (rating !== null ? String(rating) : ''), releasedate: info.releasedate || (details.release_date ?? ''), country: info.country || country, movie_image: prefer(poster, info.movie_image),