From 81bdcd644c8ae79a79de971929da75c684fb896f Mon Sep 17 00:00:00 2001
From: 4gray <fourgray@proton.me>
Date: Fri, 26 Dec 2025 00:53:04 +0100
Subject: [PATCH] refactor: move global favorites to header

---
 .../components/header/header.component.html     |  8 ++++++++
 .../components/header/header.component.ts       |  8 ++++++++
 .../recent-playlists.component.html             | 17 -----------------
 .../recent-playlists.component.ts               | 11 +----------
 4 files changed, 17 insertions(+), 27 deletions(-)

diff --git a/apps/web/src/app/shared/components/header/header.component.html b/apps/web/src/app/shared/components/header/header.component.html
index f45a226e3..3cdf2f00f 100644
--- a/apps/web/src/app/shared/components/header/header.component.html
+++ b/apps/web/src/app/shared/components/header/header.component.html
@@ -34,6 +34,14 @@
             <app-add-playlist-menu
                 (playlistTypeSelected)="openAddPlaylistDialog($event)"
             />
+            <button
+                mat-icon-button
+                (click)="navigateToGlobalFavorites()"
+                [matTooltip]="'HOME.PLAYLISTS.GLOBAL_FAVORITES' | translate"
+                data-test-id="global-favorites"
+            >
+                <mat-icon>star</mat-icon>
+            </button>
             <!-- Combined Filter & Sort button -->
             <button
                 mat-icon-button
diff --git a/apps/web/src/app/shared/components/header/header.component.ts b/apps/web/src/app/shared/components/header/header.component.ts
index 6657cb1cb..661a90247 100644
--- a/apps/web/src/app/shared/components/header/header.component.ts
+++ b/apps/web/src/app/shared/components/header/header.component.ts
@@ -18,6 +18,7 @@ import { MatTooltipModule } from '@angular/material/tooltip';
 import { ActivatedRoute, Router } from '@angular/router';
 import { TranslateModule } from '@ngx-translate/core';
 import { DataService } from 'services';
+import { GLOBAL_FAVORITES_PLAYLIST_ID } from 'shared-interfaces';
 //import { shell } from 'electron';
 import { AddPlaylistMenuComponent, PlaylistType } from 'components';
 import { HomeComponent } from '../../../home/home.component';
@@ -78,6 +79,13 @@ export class HeaderComponent implements OnInit {
         this.router.navigate(['/settings']);
     }
 
+    /**
+     * Navigates to the global favorites view
+     */
+    navigateToGlobalFavorites(): void {
+        this.router.navigate(['playlists', GLOBAL_FAVORITES_PLAYLIST_ID]);
+    }
+
     /**
      * Opens the provided URL string in new browser window
      * @param url url to open
diff --git a/libs/ui/components/src/lib/recent-playlists/recent-playlists.component.html b/libs/ui/components/src/lib/recent-playlists/recent-playlists.component.html
index b087f7f7d..183533ea8 100644
--- a/libs/ui/components/src/lib/recent-playlists/recent-playlists.component.html
+++ b/libs/ui/components/src/lib/recent-playlists/recent-playlists.component.html
@@ -14,23 +14,6 @@
                 }
             } @else {
                 <mat-nav-list class="playlists-list">
-                    <mat-list-item (click)="navigateToGlobalFavorites()">
-                        <mat-icon class="favorites-icon" matListItemIcon
-                            >star</mat-icon
-                        >
-                        <div matListItemTitle>
-                            {{
-                                'HOME.PLAYLISTS.GLOBAL_FAVORITES'
-                                    | translate
-                            }}
-                        </div>
-                        <div matListItemLine class="meta">
-                            {{
-                                'HOME.PLAYLISTS.GLOBAL_FAVORITES_DESCRIPTION'
-                                    | translate
-                            }}
-                        </div>
-                    </mat-list-item>
                     @for (
                         item of data.playlists;
                         track item._id;
diff --git a/libs/ui/components/src/lib/recent-playlists/recent-playlists.component.ts b/libs/ui/components/src/lib/recent-playlists/recent-playlists.component.ts
index a87fdcc1a..a38c25db2 100644
--- a/libs/ui/components/src/lib/recent-playlists/recent-playlists.component.ts
+++ b/libs/ui/components/src/lib/recent-playlists/recent-playlists.component.ts
@@ -18,11 +18,7 @@ import {
 import { NgxSkeletonLoaderComponent } from 'ngx-skeleton-loader';
 import { BehaviorSubject, combineLatest, map, tap } from 'rxjs';
 import { DatabaseService, DataService, SortService } from 'services';
-import {
-    GLOBAL_FAVORITES_PLAYLIST_ID,
-    PLAYLIST_UPDATE,
-    PlaylistMeta,
-} from 'shared-interfaces';
+import { PLAYLIST_UPDATE, PlaylistMeta } from 'shared-interfaces';
 import { DialogService } from '../confirm-dialog/dialog.service';
 import { PlaylistType } from '../add-playlist-menu/add-playlist-menu.component';
 import { EmptyStateComponent } from './empty-state/empty-state.component';
@@ -147,11 +143,6 @@ export class RecentPlaylistsComponent {
         );
     }
 
-    navigateToGlobalFavorites() {
-        this.router.navigate(['playlists', GLOBAL_FAVORITES_PLAYLIST_ID]);
-        this.playlistClicked.emit(GLOBAL_FAVORITES_PLAYLIST_ID);
-    }
-
     onAddPlaylist(playlistType: PlaylistType) {
         this.addPlaylistClicked.emit(playlistType);
     }