fix: use specific listener cleanup instead of removeAllListeners

Return unsubscribe function from onPlaybackPositionUpdate to ensure
only the specific listener is removed on destroy, preventing issues
with multiple store instances.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
4grayandClaude Opus 4.5 committed 2026-01-22 13:32:04 +01:00
1 parent 0219d3253e
commit 9cd278256b
3 files changed
+34 -34

No files matched your search

@@ -365,31 +365,35 @@ export function withPlaybackPositions() {
};
}),
withHooks({
onInit(store) {
if (window.electron?.onPlaybackPositionUpdate) {
window.electron.onPlaybackPositionUpdate((data: any) => {
console.log(
'[withPlaybackPositions] Received update:',
data
withHooks((store) => {
let unsubscribe: (() => void) | undefined;
return {
onInit() {
if (window.electron?.onPlaybackPositionUpdate) {
unsubscribe = window.electron.onPlaybackPositionUpdate(
(data: any) => {
console.log(
'[withPlaybackPositions] Received update:',
data
);
// Ensure playlistId is present
if (data.playlistId) {
store.savePosition(data.playlistId, data);
} else {
console.warn(
'[withPlaybackPositions] Missing playlistId in update',
data
);
}
}
);
// Ensure playlistId is present
if (data.playlistId) {
store.savePosition(data.playlistId, data);
} else {
console.warn(
'[withPlaybackPositions] Missing playlistId in update',
data
);
}
});
}
},
onDestroy(store) {
if (window.electron?.removePlaybackPositionListener) {
window.electron.removePlaybackPositionListener();
}
},
}
},
onDestroy() {
unsubscribe?.();
},
};
})
);
}