fix(downloads): journal archive promotion before publishing files

libs/shared/database/src/lib/download-schema.spec.ts

@@ -18,6 +18,7 @@ it('migrates existing downloads without losing files and separates programme ide
         const { default: Database } = await import('better-sqlite3');
         const { DOWNLOADS_TABLE_SQL, ensureDownloadsCatchupSchema } = await import(${JSON.stringify(moduleUrl)});
         const db = new Database(':memory:');
+        db.pragma('foreign_keys = ON');
         db.exec(DOWNLOADS_TABLE_SQL.replace(", 'catchup'", '').replace('programme_start INTEGER NOT NULL DEFAULT 0,', '').replace('catchup TEXT,', ''));
         db.exec("CREATE UNIQUE INDEX downloads_xtream_playlist_unique ON downloads(xtream_id, playlist_id, content_type)");
         db.prepare("INSERT INTO downloads (id,playlist_id,xtream_id,content_type,title,url,status,file_path,bytes_downloaded,resume_validator,request_headers) VALUES (42,'p',1,'vod','Movie','https://host/movie','paused','/safe/movie.mp4',123,'etag','headers')").run();
@@ -28,7 +29,11 @@ it('migrates existing downloads without losing files and separates programme ide
         let duplicateArchive = false, duplicateMovie = false;
         try { insert.run('catchup', 1000); } catch { duplicateArchive = true; }
         try { insert.run('vod', 0); } catch { duplicateMovie = true; }
-        process.stdout.write(JSON.stringify({row:db.prepare('SELECT * FROM downloads WHERE id=42').get(), count:db.prepare('SELECT count(*) AS n FROM downloads').get().n, duplicateArchive,duplicateMovie}));
+        db.prepare("INSERT INTO downloads (id,playlist_id,xtream_id,content_type,title,url) VALUES (999,'p',99,'catchup','Proof','https://host/archive')").run();
+        db.prepare("INSERT INTO download_archive_finalizations (download_id,proof) VALUES (999,'{}')").run();
+        db.prepare('DELETE FROM downloads WHERE id=999').run();
+        const journalCount = db.prepare('SELECT count(*) AS n FROM download_archive_finalizations').get().n;
+        process.stdout.write(JSON.stringify({journalCount,row:db.prepare('SELECT * FROM downloads WHERE id=42').get(), count:db.prepare('SELECT count(*) AS n FROM downloads').get().n, duplicateArchive,duplicateMovie}));
     `,
         ],
         {
@@ -43,6 +48,7 @@ it('migrates existing downloads without losing files and separates programme ide
     );
     expect(JSON.parse(result)).toMatchObject({
         count: 3,
+        journalCount: 0,
         duplicateArchive: true,
         duplicateMovie: true,
         row: {

libs/shared/database/src/lib/download-schema.ts

@@ -32,6 +32,11 @@ export const DOWNLOADS_INDEX_STATEMENTS = [
     `CREATE INDEX IF NOT EXISTS downloads_status_idx ON downloads(status)`,
 ];
 
+const ARCHIVE_FINALIZATIONS_SQL = `CREATE TABLE IF NOT EXISTS download_archive_finalizations (
+    download_id INTEGER PRIMARY KEY REFERENCES downloads(id) ON DELETE CASCADE,
+    proof TEXT NOT NULL
+)`;
+
 const CATCHUP_INDEX = `CREATE UNIQUE INDEX IF NOT EXISTS downloads_catchup_unique
     ON downloads(xtream_id, playlist_id, programme_start) WHERE content_type = 'catchup'`;
 
@@ -45,6 +50,7 @@ export function ensureDownloadsCatchupSchema(db: Database.Database): void {
     if (!row) return;
     if (row.sql.includes("'catchup'")) {
         db.exec(CATCHUP_INDEX);
+        db.exec(ARCHIVE_FINALIZATIONS_SQL);
         return;
     }
     const columns = [
@@ -83,5 +89,6 @@ export function ensureDownloadsCatchupSchema(db: Database.Database): void {
         db.exec('DROP TABLE downloads_catchup_legacy');
         for (const statement of DOWNLOADS_INDEX_STATEMENTS) db.exec(statement);
         db.exec(CATCHUP_INDEX);
+        db.exec(ARCHIVE_FINALIZATIONS_SQL);
     })();
 }

libs/shared/database/src/lib/download-tables.ts

@@ -0,0 +1,84 @@
+import type { CatchupDownloadMetadata } from '@iptvnator/shared/interfaces';
+import { sql } from 'drizzle-orm';
+import {
+    index,
+    integer,
+    sqliteTable,
+    text,
+    uniqueIndex,
+} from 'drizzle-orm/sqlite-core';
+
+// Downloads table
+export const downloads = sqliteTable(
+    'downloads',
+    {
+        id: integer('id').primaryKey({ autoIncrement: true }),
+        playlistId: text('playlist_id').notNull(),
+        // Content identifiers
+        xtreamId: integer('xtream_id').notNull(),
+        contentType: text('content_type', {
+            enum: ['vod', 'episode', 'catchup'],
+        }).notNull(),
+        programmeStart: integer('programme_start').notNull().default(0),
+        catchup: text('catchup', {
+            mode: 'json',
+        }).$type<CatchupDownloadMetadata>(),
+        // For episodes: store series info
+        seriesXtreamId: integer('series_xtream_id'),
+        seasonNumber: integer('season_number'),
+        episodeNumber: integer('episode_number'),
+        episodeIdentityScope: text('episode_identity_scope'),
+        // Download metadata
+        title: text('title').notNull(),
+        url: text('url').notNull(),
+        fileName: text('file_name'),
+        filePath: text('file_path'),
+        posterUrl: text('poster_url'),
+        requestHeaders: text('request_headers'),
+        resumeValidator: text('resume_validator'),
+        metadataSnapshot: text('metadata_snapshot'),
+        // Download progress
+        status: text('status', {
+            enum: [
+                'queued',
+                'downloading',
+                'paused',
+                'completed',
+                'failed',
+                'canceled',
+            ],
+        })
+            .notNull()
+            .default('queued'),
+        bytesDownloaded: integer('bytes_downloaded').default(0),
+        totalBytes: integer('total_bytes'),
+        errorMessage: text('error_message'),
+        // Timestamps
+        createdAt: text('created_at').default(sql`CURRENT_TIMESTAMP`),
+        updatedAt: text('updated_at').default(sql`CURRENT_TIMESTAMP`),
+    },
+    (table) => ({
+        playlistIdx: index('downloads_playlist_idx').on(table.playlistId),
+        statusIdx: index('downloads_status_idx').on(table.status),
+        xtreamPlaylistUnique: uniqueIndex('downloads_xtream_playlist_unique')
+            .on(table.xtreamId, table.playlistId, table.contentType)
+            .where(sql`${table.contentType} != 'catchup'`),
+        catchupUnique: uniqueIndex('downloads_catchup_unique')
+            .on(table.xtreamId, table.playlistId, table.programmeStart)
+            .where(sql`${table.contentType} = 'catchup'`),
+    })
+);
+
+export type Download = typeof downloads.$inferSelect;
+export type NewDownload = typeof downloads.$inferInsert;
+
+// Write-ahead archive promotion proof. It outlives process-local DownloadTask.
+export const downloadArchiveFinalizations = sqliteTable(
+    'download_archive_finalizations',
+    {
+        downloadId: integer('download_id')
+            .primaryKey()
+            .references(() => downloads.id, { onDelete: 'cascade' }),
+        proof: text('proof').notNull(),
+    }
+);

libs/shared/database/src/lib/schema.ts

@@ -1,4 +1,3 @@
-import type { CatchupDownloadMetadata } from '@iptvnator/shared/interfaces';
 /**
  * Drizzle ORM schema for IPTVnator database
  * This schema defines the structure for Xtream Codes API data storage
@@ -336,69 +335,7 @@ export type NewEpgProgramDb = typeof epgPrograms.$inferInsert;
 export type PlaybackPosition = typeof playbackPositions.$inferSelect;
 export type NewPlaybackPosition = typeof playbackPositions.$inferInsert;
 
-// Downloads table
-export const downloads = sqliteTable(
-    'downloads',
-    {
-        id: integer('id').primaryKey({ autoIncrement: true }),
-        playlistId: text('playlist_id').notNull(),
-        // Content identifiers
-        xtreamId: integer('xtream_id').notNull(),
-        contentType: text('content_type', {
-            enum: ['vod', 'episode', 'catchup'],
-        }).notNull(),
-        programmeStart: integer('programme_start').notNull().default(0),
-        catchup: text('catchup', {
-            mode: 'json',
-        }).$type<CatchupDownloadMetadata>(),
-        // For episodes: store series info
-        seriesXtreamId: integer('series_xtream_id'),
-        seasonNumber: integer('season_number'),
-        episodeNumber: integer('episode_number'),
-        episodeIdentityScope: text('episode_identity_scope'),
-        // Download metadata
-        title: text('title').notNull(),
-        url: text('url').notNull(),
-        fileName: text('file_name'),
-        filePath: text('file_path'),
-        posterUrl: text('poster_url'),
-        requestHeaders: text('request_headers'),
-        resumeValidator: text('resume_validator'),
-        metadataSnapshot: text('metadata_snapshot'),
-        // Download progress
-        status: text('status', {
-            enum: [
-                'queued',
-                'downloading',
-                'paused',
-                'completed',
-                'failed',
-                'canceled',
-            ],
-        })
-            .notNull()
-            .default('queued'),
-        bytesDownloaded: integer('bytes_downloaded').default(0),
-        totalBytes: integer('total_bytes'),
-        errorMessage: text('error_message'),
-        // Timestamps
-        createdAt: text('created_at').default(sql`CURRENT_TIMESTAMP`),
-        updatedAt: text('updated_at').default(sql`CURRENT_TIMESTAMP`),
-    },
-    (table) => ({
-        playlistIdx: index('downloads_playlist_idx').on(table.playlistId),
-        statusIdx: index('downloads_status_idx').on(table.status),
-        xtreamPlaylistUnique: uniqueIndex('downloads_xtream_playlist_unique')
-            .on(table.xtreamId, table.playlistId, table.contentType)
-            .where(sql`${table.contentType} != 'catchup'`),
-        catchupUnique: uniqueIndex('downloads_catchup_unique')
-            .on(table.xtreamId, table.playlistId, table.programmeStart)
-            .where(sql`${table.contentType} = 'catchup'`),
-    })
-);
-
-export type Download = typeof downloads.$inferSelect;
-export type NewDownload = typeof downloads.$inferInsert;
+export * from './download-tables';
 
 // Live-TV recordings table. Rows are created by the embedded-MPV recording
 // tracker, not by the download queue: a recording has no source URL to