mirror of
https://github.com/EasyTier/EasyTier.git
synced 2026-10-16 09:36:14 -08:00
fix(config): preserve and patch empty manual route mode (#2709)
* fix(config): preserve empty manual route mode in API conversion Treat present TOML routes as manual mode even when the list is empty. Both Core readback and Web normalization must distinguish routes=[] from automatic discovery; otherwise Web can skip a required overwrite and Core can report a different mode from its running configuration. Cover API/TOML round trips and receiver reconcile mode transitions. Verify default-feature tests, clippy, formatting and real system routes in three isolated Linux network namespaces. * fix(config): patch manual route mode and verify legacy readback Add an explicit manual-route mode to route patches and advertise typed readback support through GetConfig. Apply the mode and route edits in the existing route transaction without restarting the instance; keep released callers that omit the new field on their existing route semantics. Web gates route patches on the observed capability. For old clients with ambiguous empty routes, recover the actual mode from GetConfig TOML or instance-scoped ShowNodeInfo before acknowledging application. Supporting clients use typed readback directly. Keep capability evidence in the existing session cache and preserve its invalidation rules. Cover mode transitions, persistence failure, stable peer identity, legacy readback, compact clients, failed observations and cache capability gates. Document the runtime contract and compatibility boundary. * refactor(web): advertise route patch support in heartbeats Declare manual-route patch and typed readback support on the WebClient heartbeat alongside existing client capabilities. Select route updates and legacy readback from the current authenticated Session heartbeat, including when reconciliation reuses an observed configuration. Remove the unreleased GetConfig capability field and per-instance capability wrapper. Keep only observed configuration in the existing cache, and retain strict application confirmation after full Run. Cover the client declaration, legacy default and capability changes against the same cached configuration. Update the runtime contract. --------- Co-authored-by: Codex <codex@users.noreply.github.com>
This commit is contained in:
1 parent
7588062f7e
commit
99db92a3ae
14 files changed
+702
-132
No files matched your search
@@ -502,6 +502,28 @@ behavior:
|
||||
- gateway and connectivity settings;
|
||||
- runtime configuration patches.
|
||||
|
||||
Manual routing retains three distinct states: absent routes select automatic
|
||||
routing, a present empty list installs no remote subnet routes, and a present
|
||||
nonempty list selects explicit routes. `NetworkConfig.enable_manual_routes`
|
||||
preserves this distinction on readback. `InstanceConfigPatch` applies its
|
||||
optional `enable_manual_routes` together with route edits in one route
|
||||
sub-patch: true retains an empty manual list and false restores automatic
|
||||
routing. Omitting the mode preserves released RoutePatch behavior, including
|
||||
returning to automatic routing when the edited list becomes empty. This does
|
||||
not change the ordered partial-commit contract of a multi-field patch.
|
||||
|
||||
`HeartbeatRequest.support_manual_routes_patch` advertises this complete route
|
||||
contract, including typed empty-manual readback, on the WebClient Session.
|
||||
The Web controller uses the current authenticated heartbeat to choose route
|
||||
patches; observed instance configuration caches contain no capability state.
|
||||
Released clients omit the flag and still receive
|
||||
full configuration replacements for route changes. For their ambiguous empty
|
||||
readback, Web reads the existing `GetConfig.toml_config`, or, when absent, the
|
||||
instance-scoped `ShowNodeInfo` TOML used by 2.6.4. It reads only the instance ID
|
||||
and route field, requires a matching instance, and confirms the actual mode
|
||||
before recording application. Supporting clients use typed readback directly;
|
||||
compact clients with raw GetConfig need no Peer management RPC.
|
||||
|
||||
Host persistence is an effect following a successful core transaction. A Host
|
||||
Adapter must not call back into an instance to obtain a hidden configuration
|
||||
snapshot while core is applying an operation.
|
||||
|
||||
Reference in new issue
Block a user