Refactor Setting class to fix state loss issue, update range callback return type, and remove isStringOrNumber utility function

This commit is contained in:
Harvey Zack committed 2024-10-20 13:56:22 +08:00
1 parent 191c7736c4
commit b949fedc06
9 files changed
+22 -40

No files matched your search

+1 -2
View File
@@ -17,7 +17,6 @@ import {
createElement,
replaceElement,
includeFromEvent,
isStringOrNumber,
} from '../utils';
export default class Setting extends Component {
@@ -455,7 +454,7 @@ export default class Setting extends Component {
if (item.$parent && item.$parent.onSelect) {
const result = await item.$parent.onSelect.call(this.art, item, $item, event);
if (item.$parent.$tooltip && isStringOrNumber(result)) {
if (item.$parent.$tooltip) {
item.$parent.$tooltip.innerHTML = result;
}
}