test(ci): [CI-01] checkpoint verified Ads installed browser coverage

test/browser/ads-ui.spec.js

@@ -1,20 +1,20 @@
-import fs from 'node:fs'
 import process from 'node:process'
 import { hash } from '../../refactor/scripts/releases.mjs'
-import { compilePackage } from '../helpers/load.js'
+import { browserCandidate } from '../helpers/browser-candidate.js'
 import { expect, test } from './fixtures.js'
 
 let candidate
+let provenance
 test.beforeAll(async () => {
-  candidate = process.env.ARTPLAYER_ADS_ARTIFACT
-    ? fs.readFileSync(process.env.ARTPLAYER_ADS_ARTIFACT, 'utf8')
-    : await compilePackage('artplayer-plugin-ads', 'umd')
+  const input = await browserCandidate('artplayer-plugin-ads', process.env.ARTPLAYER_ADS_ARTIFACT)
+  candidate = input.code
+  provenance = input.provenance
 })
 
 async function setup(page, core, testInfo, option = {}) {
   await page.goto(`/test/player.html?core=${core}`)
   await page.addScriptTag({ content: candidate })
-  await testInfo.attach('ads-ui-inputs', { contentType: 'application/json', body: JSON.stringify({ core, artifact: process.env.ARTPLAYER_ADS_ARTIFACT || 'workspace source build', sha256: hash(candidate) }) })
+  await testInfo.attach('ads-ui-inputs', { contentType: 'application/json', body: JSON.stringify({ core, artifact: provenance, sha256: hash(candidate) }) })
   await page.evaluate((option) => {
     window.adsEvents = []
     window.art = new window.Artplayer({ container: '.player', url: '/test/pattern.mp4', muted: true, mutex: false, plugins: [window.artplayerPluginAds({ html: 'ad', totalDuration: 60, playDuration: 0, ...option })] })

test/browser/ads.spec.js

@@ -2,12 +2,13 @@ import assert from 'node:assert/strict'
 import fs from 'node:fs'
 import process from 'node:process'
 import { ensureArchive, hash, readMember } from '../../refactor/scripts/releases.mjs'
-import { compilePackage } from '../helpers/load.js'
+import { browserCandidate } from '../helpers/browser-candidate.js'
 import { expect, test } from './fixtures.js'
 
 let published
 let candidate
 let release
+let provenance
 
 test.beforeAll(async () => {
   release = JSON.parse(fs.readFileSync(new URL('../../refactor/baselines/ads-release.json', import.meta.url))).release
@@ -15,9 +16,9 @@ test.beforeAll(async () => {
   const bytes = readMember(await ensureArchive(release), member)
   assert.equal(hash(bytes), release.files[member])
   published = bytes.toString()
-  candidate = process.env.ARTPLAYER_ADS_ARTIFACT
-    ? fs.readFileSync(process.env.ARTPLAYER_ADS_ARTIFACT, 'utf8')
-    : await compilePackage('artplayer-plugin-ads', 'umd')
+  const input = await browserCandidate('artplayer-plugin-ads', process.env.ARTPLAYER_ADS_ARTIFACT)
+  candidate = input.code
+  provenance = input.provenance
 })
 
 test.afterEach(async ({ page }, testInfo) => {
@@ -45,7 +46,7 @@ async function openAds(page, core, plugin, option, testInfo, start = true) {
   await page.goto(`/test/player.html?core=${core}`)
   const code = plugin === 'published' ? published : candidate
   await page.addScriptTag({ content: code })
-  await testInfo.attach('ads-inputs', { contentType: 'application/json', body: JSON.stringify({ core, plugin, release: plugin === 'published' ? release : undefined, sha256: hash(code), artifact: plugin === 'candidate' ? process.env.ARTPLAYER_ADS_ARTIFACT || 'workspace source build' : undefined }) })
+  await testInfo.attach('ads-inputs', { contentType: 'application/json', body: JSON.stringify({ core, plugin, release: plugin === 'published' ? release : undefined, sha256: hash(code), artifact: plugin === 'candidate' ? provenance : undefined }) })
   await page.evaluate((option) => {
     window.adsEvents = []
     window.art = new window.Artplayer({

test/helpers/browser-candidate.js

@@ -0,0 +1,22 @@
+import assert from 'node:assert/strict'
+import fs from 'node:fs'
+import process from 'node:process'
+import { fileURLToPath } from 'node:url'
+import { hash } from '../../refactor/scripts/releases.mjs'
+import { verifyInstalledArtifacts } from '../../scripts/installed-artifacts.mjs'
+import { compilePackage } from './load.js'
+
+const root = fileURLToPath(new URL('../../', import.meta.url))
+
+export async function browserCandidate(name, artifact) {
+  const map = process.env.ARTPLAYER_BROWSER_ARTIFACTS
+  if (map) {
+    assert(!artifact, `Installed browser checks cannot override ${name} artifact`)
+    const { inputs } = verifyInstalledArtifacts(root, map, ['artplayer', 'artplayer-plugin-chapter', name])
+    const input = inputs.find(input => input.name === name)
+    const code = fs.readFileSync(input.file, 'utf8')
+    return { code, provenance: { kind: 'installed', ...input } }
+  }
+  const code = artifact ? fs.readFileSync(artifact, 'utf8') : await compilePackage(name, 'umd')
+  return { code, provenance: { kind: artifact ? 'explicit-artifact' : 'source-build', file: artifact || null, sha256: hash(code) } }
+}

test/package-check.test.js

@@ -8,6 +8,7 @@ import { checkFiles, checkPackages, publishedConsumer } from '../scripts/package
 import { removeConsumer, runtimeConsumer } from '../scripts/package-consumer.mjs'
 import { emitterContracts } from './contracts/emitter.js'
 import { ambilightCandidate } from './helpers/ambilight.js'
+import { browserCandidate } from './helpers/browser-candidate.js'
 import { canvasCandidate } from './helpers/canvas.js'
 import { dpipCandidate } from './helpers/dpip.js'
 
@@ -28,6 +29,8 @@ test('Explicit installed plugin maps never fall back to source or frozen workspa
     await assert.rejects(ambilightCandidate(), { code: 'ENOENT' })
     await assert.rejects(canvasCandidate(), { code: 'ENOENT' })
     await assert.rejects(dpipCandidate(), { code: 'ENOENT' })
+    await assert.rejects(browserCandidate('artplayer-plugin-ads'), { code: 'ENOENT' })
+    await assert.rejects(browserCandidate('artplayer-plugin-ads', 'override.js'), /cannot override artplayer-plugin-ads artifact/)
     process.env.ARTPLAYER_AMBILIGHT_BASELINE = '1'
     process.env.ARTPLAYER_CANVAS_BASELINE = '1'
     process.env.ARTPLAYER_DPIP_BASELINE = '1'

test/package/README.md

@@ -9,9 +9,9 @@ step through `ARTPLAYER_BROWSER_ARTIFACTS`. See
 browser scope and the remaining package-specific release gates.
 
 Run `yarn test:package` with the pinned Node and Yarn after a frozen install. The
-default consumer scope is core and chapter. For Ambilight/Canvas/Document PiP browser work,
-run `yarn test:package --include=artplayer-plugin-ambilight,artplayer-proxy-canvas,artplayer-plugin-document-pip`.
-These three additional packages have reviewed published contracts and use the same
+default consumer scope is core and chapter. For Ambilight/Canvas/Document PiP/Ads browser work,
+run `yarn test:package --include=artplayer-plugin-ambilight,artplayer-proxy-canvas,artplayer-plugin-document-pip,artplayer-plugin-ads`.
+These four additional packages have reviewed published contracts and use the same
 source snapshot/build/pack/offline-install/frozen-reinstall pipeline. Installed
 files are copied only after archive hash checks. The report explicitly separates
 the core/chapter runtime/type scope from the additional browser package scope;