mirror of
https://github.com/zhw2590582/ArtPlayer.git
synced 2026-10-23 22:01:20 -08:00
feat: add option to remove video source on destroy
- Introduced a new static property REMOVE_SRC_WHEN_DESTROY in Artplayer to control whether the video source should be removed when the player is destroyed. - Updated the destroy method in Artplayer to conditionally remove the video source based on the new property. - Removed the line that sets the video source to an empty string in the Template class's destroy method, as this is now handled in Artplayer. - Updated TypeScript definitions to include the new REMOVE_SRC_WHEN_DESTROY property.
This commit is contained in:
1 parent
cb3d391c34
commit
9bfd535e57
6 files changed
+9
-3
No files matched your search
@@ -203,6 +203,9 @@ export default class Artplayer extends Emitter {
|
||||
}
|
||||
|
||||
destroy(removeHtml = true) {
|
||||
if (Artplayer.REMOVE_SRC_WHEN_DESTROY) {
|
||||
this.video.removeAttribute('src')
|
||||
}
|
||||
this.events.destroy()
|
||||
this.template.destroy(removeHtml)
|
||||
instances.splice(instances.indexOf(this), 1)
|
||||
@@ -244,6 +247,7 @@ Artplayer.FLIP = ['normal', 'horizontal', 'vertical']
|
||||
Artplayer.FULLSCREEN_WEB_IN_BODY = false
|
||||
Artplayer.LOG_VERSION = true
|
||||
Artplayer.USE_RAF = false
|
||||
Artplayer.REMOVE_SRC_WHEN_DESTROY = true
|
||||
|
||||
if (utils.isBrowser) {
|
||||
window.Artplayer = Artplayer
|
||||
|
||||
@@ -147,7 +147,6 @@ export default class Template {
|
||||
}
|
||||
|
||||
destroy(removeHtml) {
|
||||
this.$video.src = ''
|
||||
if (removeHtml) {
|
||||
this.$container.innerHTML = ''
|
||||
}
|
||||
|
||||
+1
@@ -86,6 +86,7 @@ export default class Artplayer extends Player {
|
||||
static FULLSCREEN_WEB_IN_BODY: boolean
|
||||
static LOG_VERSION: boolean
|
||||
static USE_RAF: boolean
|
||||
static REMOVE_SRC_WHEN_DESTROY: boolean
|
||||
|
||||
readonly id: number
|
||||
readonly option: Option
|
||||
|
||||
Reference in new issue
Block a user