refactor(auto-thumbnail): [PKG-AUTO-THUMB-03] wait for native frame presentation

test/browser/auto-thumbnail-lifecycle.spec.js

@@ -3,21 +3,29 @@ import { autoThumbnailCandidate } from '../helpers/auto-thumbnail.js'
 import { expect, test } from './fixtures.js'
 
 const implementation = await autoThumbnailCandidate()
-for (const scenario of ['destroy', 'restart', 'complete']) {
+for (const scenario of ['destroy', 'restart', 'complete', 'frame-destroy', 'frame-restart']) {
   test(`Auto-thumbnail candidate native ${scenario} owns decoder and encoded URLs`, async ({ page }, testInfo) => {
     await page.goto('/test/player.html?core=published')
     await page.setContent('<!doctype html><div></div>')
     await page.addScriptTag({ content: implementation.code })
-    await page.evaluate(async (hold) => {
-      const probe = window.probe = { videos: [], updates: [], urls: new Set(), blobs: [], listeners: new Map(), hold }
+    await page.evaluate(async (scenario) => {
+      const probe = window.probe = { videos: [], updates: [], urls: new Set(), blobs: [], frames: [], frameSupport: false, listeners: new Map(), hold: scenario !== 'complete' }
       const createElement = document.createElement.bind(document)
       const createUrl = URL.createObjectURL.bind(URL)
       const revokeUrl = URL.revokeObjectURL.bind(URL)
       const toBlob = HTMLCanvasElement.prototype.toBlob
       document.createElement = function (name, ...args) {
         const element = createElement(name, ...args)
-        if (name === 'video')
+        if (name === 'video') {
           probe.videos.push(element)
+          const request = element.requestVideoFrameCallback?.bind(element)
+          probe.frameSupport = Boolean(request && element.cancelVideoFrameCallback)
+          if (probe.frameSupport && scenario.startsWith('frame-')) {
+            element.requestVideoFrameCallback = callback => request((...args) => {
+              probe.frames.push({ callback, args })
+            })
+          }
+        }
         return element
       }
       HTMLCanvasElement.prototype.toBlob = function (callback, type) {
@@ -63,32 +71,41 @@ for (const scenario of ['destroy', 'restart', 'complete']) {
       }
       probe.result = await window.artplayerPluginAutoThumbnail({ width: 80, number: 2 })(probe.art)
       probe.art.emit('video:loadedmetadata')
-    }, scenario !== 'complete')
-    await expect.poll(() => page.evaluate(() => window.probe.blobs.length)).toBe(scenario === 'complete' ? 2 : 1)
+    }, scenario)
+    const holdFrame = scenario.startsWith('frame-') && await page.evaluate(() => window.probe.frameSupport)
+    await expect.poll(() => page.evaluate(holdFrame => holdFrame ? window.probe.frames.length : window.probe.blobs.length, holdFrame)).toBe(scenario === 'complete' ? 2 : 1)
     const state = await page.evaluate((scenario) => {
       const probe = window.probe
       const before = { urls: probe.urls.size, updates: probe.updates.length }
       if (scenario !== 'complete') {
-        probe.art.emit(scenario)
-        probe.blobs[0].callback(probe.blobs[0].blob)
-        probe.blobs[0].callback(probe.blobs[0].blob)
+        probe.art.emit(scenario.replace('frame-', ''))
+        if (probe.blobs[0]) {
+          probe.blobs[0].callback(probe.blobs[0].blob)
+          probe.blobs[0].callback(probe.blobs[0].blob)
+        }
+        if (probe.frames[0]) {
+          probe.frames[0].callback(...probe.frames[0].args)
+          probe.frames[0].callback(...probe.frames[0].args)
+        }
       }
       const after = { urls: probe.urls.size, updates: probe.updates.length }
       const decoder = probe.videos[0]
-      const video = { connected: decoder.isConnected, src: decoder.getAttribute('src'), readyState: decoder.readyState, paused: decoder.paused, handlers: ['onloadedmetadata', 'onseeked', 'onerror'].map(key => decoder[key] === null) }
+      const video = { connected: decoder.isConnected, src: decoder.getAttribute('src'), readyState: decoder.readyState, paused: decoder.paused, handlers: ['onloadedmetadata', 'onloadeddata', 'onseeked', 'onerror'].map(key => decoder[key] === null) }
       probe.art.emit('destroy')
       probe.art.emit('destroy')
       const final = { urls: probe.urls.size, listeners: [...probe.listeners.values()].reduce((sum, set) => sum + set.size, 0), updates: probe.updates.length }
       const blobs = probe.blobs.map(({ blob }) => ({ type: blob.type, bytes: blob.size }))
       probe.restore()
-      return { before, after, video, final, blobs, result: probe.result }
+      return { before, after, video, final, blobs, heldFrames: probe.frames.length, frameSupport: probe.frameSupport, result: probe.result }
     }, scenario)
-    await testInfo.attach('auto-thumbnail-candidate-native-lifecycle', { contentType: 'application/json', body: JSON.stringify({ scenario, sha256: hash(implementation.code), scope: 'Actual HTTP decoding/seek/JPEG lifecycle with a stub player host. This checkpoint does not establish accurate extracted pixels; AUTO-THUMB-PIXEL-01 remains open.', ...state }) })
+    await testInfo.attach('auto-thumbnail-candidate-native-lifecycle', { contentType: 'application/json', body: JSON.stringify({ scenario, sha256: hash(implementation.code), scope: 'Actual HTTP decoding/seek/JPEG and held native presentation callback lifecycle with a stub player host. Frame scenarios use a held Blob fallback only when native frame callbacks are absent. Pixel acceptance is separate; AUTO-THUMB-PIXEL-01 remains open.', ...state }) })
     expect(state.result).toEqual({ name: 'artplayerPluginAutoThumbnail' })
     expect(state.before).toEqual(scenario === 'complete' ? { urls: 1, updates: 2 } : { urls: 0, updates: 0 })
     expect(state.after).toEqual(state.before)
-    expect(state.video).toEqual({ connected: false, src: null, readyState: 0, paused: true, handlers: [true, true, true] })
+    expect(state.video).toEqual({ connected: false, src: null, readyState: 0, paused: true, handlers: [true, true, true, true] })
     expect(state.final).toEqual({ urls: 0, listeners: 0, updates: scenario === 'complete' ? 2 : 0 })
     expect(state.blobs.every(blob => blob.type === 'image/jpeg' && blob.bytes > 0)).toBe(true)
+    expect(state.heldFrames).toBe(holdFrame ? 1 : 0)
+    expect(state.blobs).toHaveLength(holdFrame ? 0 : scenario === 'complete' ? 2 : 1)
   })
 }