perf(core): [MOD-03] avoid redundant slider attribute writes

This commit is contained in:
Harvey Zhao committed 2026-09-14 15:44:18 +08:00
1 parent 7b0e1d156b
commit 23a4f22b72
18 files changed
+6012 -28

No files matched your search

+10 -5
View File
@@ -12,6 +12,11 @@ interface Range {
const directions = new Map([['ArrowRight', 1], ['ArrowUp', 1], ['ArrowLeft', -1], ['ArrowDown', -1], ['PageUp', 10], ['PageDown', -10]])
function updateAttribute(element: HTMLElement, name: string, value: string): void {
if (element.getAttribute(name) !== value)
element.setAttribute(name, value)
}
export function keyboardSlider(scope: ResourceScope, element: HTMLElement, label: string, read: () => Range, write: (value: number) => void, orientation = 'horizontal'): () => void {
const valid = (range: Range) => [range.min, range.max, range.value, range.step].every(Number.isFinite) && range.max > range.min && range.step > 0
const clamp = (value: number, range: Range) => Math.min(range.max, Math.max(range.min, value))
@@ -21,11 +26,11 @@ export function keyboardSlider(scope: ResourceScope, element: HTMLElement, label
const range = read()
const enabled = valid(range)
const value = enabled ? clamp(range.value, range) : 0
element.setAttribute('aria-disabled', String(!enabled))
element.setAttribute('aria-valuemin', String(enabled ? range.min : 0))
element.setAttribute('aria-valuemax', String(enabled ? range.max : 0))
element.setAttribute('aria-valuenow', String(value))
element.setAttribute('aria-valuetext', range.text(value))
updateAttribute(element, 'aria-disabled', String(!enabled))
updateAttribute(element, 'aria-valuemin', String(enabled ? range.min : 0))
updateAttribute(element, 'aria-valuemax', String(enabled ? range.max : 0))
updateAttribute(element, 'aria-valuenow', String(value))
updateAttribute(element, 'aria-valuetext', range.text(value))
}
if (scope.closed)
return update