fix(thumbnail): [PKG-TOOL-THUMB-07] preserve falsy cleanup exceptions

test/browser/thumbnail-emitter.spec.js

@@ -1,9 +1,43 @@
 import { hash } from '../../refactor/scripts/releases.mjs'
-import { thumbnailCandidate } from '../helpers/thumbnail.js'
+import { thumbnailCandidate, thumbnailHistorical } from '../helpers/thumbnail.js'
 import { expect, test } from './fixtures.js'
 
 const candidate = await thumbnailCandidate()
 
+for (const implementation of [...thumbnailHistorical(), candidate]) {
+  test(`Thumbnail ${implementation.name}: destroy preserves falsy listener exceptions with real DOM cleanup`, async ({ page }, testInfo) => {
+    await page.goto('/test/player.html?core=candidate&chapter=published')
+    await page.addScriptTag({ content: implementation.code })
+    const result = await page.evaluate(() => {
+      return [undefined, null, false, 0, -0, '', Number.NaN].map((failure, index) => {
+        const input = document.createElement('input')
+        input.type = 'file'
+        document.body.append(input)
+        const tool = new window.ArtplayerToolThumbnail({ fileInput: input })
+        let notified = 0
+        let threw = false
+        let same = false
+        tool.on('destroy', () => {
+          notified++
+          throw failure
+        })
+        try {
+          tool.destroy()
+        }
+        catch (error) {
+          threw = true
+          same = Object.is(error, failure)
+        }
+        const videoConnected = tool.video.isConnected
+        input.remove()
+        return { index, threw, same, notified, videoConnected }
+      })
+    })
+    await testInfo.attach('thumbnail-cleanup-errors', { contentType: 'application/json', body: JSON.stringify({ implementation: implementation.name, sha256: hash(implementation.code), result }) })
+    expect(result).toEqual(Array.from({ length: 7 }, (_, index) => ({ index, threw: true, same: true, notified: 1, videoConnected: false })))
+  })
+}
+
 test('Thumbnail native browser event registry handles special names and nested once without changing DOM cleanup', async ({ page }, testInfo) => {
   await page.goto('/test/player.html?core=candidate&chapter=published')
   await page.addScriptTag({ content: candidate.code })
@@ -11,7 +45,7 @@ test('Thumbnail native browser event registry handles special names and nested o
     const input = document.createElement('input')
     input.type = 'file'
     document.body.append(input)
-    const tool = new ArtplayerToolThumbnail({ fileInput: input })
+    const tool = new window.ArtplayerToolThumbnail({ fileInput: input })
     const keys = []
     for (const name of ['__proto__', 'constructor', 'toString', 'hasOwnProperty']) {
       let calls = 0
@@ -23,7 +57,7 @@ test('Thumbnail native browser event registry handles special names and nested o
     }
     let nested = false
     const seen = []
-    tool.on('custom', value => {
+    tool.on('custom', (value) => {
       if (!nested) {
         nested = true
         tool.emit('custom', 'inner')